[ntp4] Make top level Bookmark Manager links point to the bookmarks bar folder.

chrome/browser/resources/ntp4/bookmarks_page.js

Index: chrome/browser/resources/ntp4/bookmarks_page.js
===================================================================
--- chrome/browser/resources/ntp4/bookmarks_page.js	(revision 101977)
+++ chrome/browser/resources/ntp4/bookmarks_page.js	(working copy)
@@ -299,13 +299,14 @@
       for (var i = 0; i < tile_count; i++)
         this.appendTile(new Bookmark(items[i]), false);
 
+      var folder_id = this.id == ROOT_NODE_ID ? BOOKMARKS_BAR_ID : this.id;
       var link = $('bookmarks-top-link-wrapper').querySelector('a');
-      link.href = 'chrome://bookmarks/#' + this.id;
+      link.href = 'chrome://bookmarks/#' + folder_id;
 
       var wrapper = $('bookmarks-bottom-link-wrapper');
       if (items.length > MAX_BOOKMARK_TILES) {
         var link = wrapper.querySelector('a');

[Evan Stade, 2011/09/21 22:13:23]

confusing link variable shadowing here :(

[csilv, 2011/09/21 23:45:26]

Indeed, fixed.

-        link.href = 'chrome://bookmarks/#' + this.id;
+        link.href = 'chrome://bookmarks/#' + folder_id;
         wrapper.hidden = false;
       } else {
         wrapper.hidden = true;