[ntp4] Make top level Bookmark Manager links point to the bookmarks bar folder.

chrome/browser/resources/ntp4/bookmarks_page.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp4', function() {
   'use strict';
 
   var localStrings = new LocalStrings;
 
   /**
@@ skipping 281 matching lines @@
      * Build the bookmark tiles.
      * @param {Array} items The contents of the current folder.
      * @private
      */
     updateBookmarkTiles_: function(items) {
       this.removeAllTiles();
       var tile_count = Math.min(items.length, MAX_BOOKMARK_TILES);
       for (var i = 0; i < tile_count; i++)
         this.appendTile(new Bookmark(items[i]), false);
 
+      var folder_id = this.id == ROOT_NODE_ID ? BOOKMARKS_BAR_ID : this.id;
       var link = $('bookmarks-top-link-wrapper').querySelector('a');
-      link.href = 'chrome://bookmarks/#' + this.id;
+      link.href = 'chrome://bookmarks/#' + folder_id;
 
       var wrapper = $('bookmarks-bottom-link-wrapper');
       if (items.length > MAX_BOOKMARK_TILES) {
         var link = wrapper.querySelector('a');

[Evan Stade, 2011/09/21 22:13:23]

confusing link variable shadowing here :(

[csilv, 2011/09/21 23:45:26]

Indeed, fixed.

-        link.href = 'chrome://bookmarks/#' + this.id;
+        link.href = 'chrome://bookmarks/#' + folder_id;
         wrapper.hidden = false;
       } else {
         wrapper.hidden = true;
       }
 
       if (this.id === ROOT_NODE_ID && !tile_count && !cr.isChromeOS)
         this.showImportPromo_();
     },
 
     /**
@@ skipping 314 matching lines @@
       tile.stripeColor = color;
   }
 
   return {
     BookmarksPage: BookmarksPage,
     initBookmarkChevron: initBookmarkChevron,
   };
 });
 
 window.addEventListener('load', ntp4.initBookmarkChevron);