Issue 7976003: Fix new space shrinking to reset from-space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7976003: Fix new space shrinking to reset from-space. (Closed)

Created:
9 years, 3 months ago by Michael Starzinger

Modified:
9 years, 3 months ago

Reviewers:
Lasse Reichstein, Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix new space shrinking to reset from-space. R=lrn@chromium.org BUG=v8:1702 TEST=cctest/test-heap/GrowAndShrinkNewSpace Committed: http://code.google.com/p/v8/source/detail?r=9346

Patch Set 2 : Addressed comments by Lasse Reichstein. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -6 lines)			Patch
	M	src/spaces.cc	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
	M	test/cctest/test-heap.cc	View		1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

lgtm http://codereview.chromium.org/7976003/diff/1/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/7976003/diff/1/src/spaces.cc#newcode950 src/spaces.cc:950: from_space_.Reset(); Could you change "from space" to "from-space" ...

9 years, 3 months ago (2011-09-20 13:28:38 UTC) #2

Michael Starzinger

9 years, 3 months ago (2011-09-20 13:34:17 UTC) #4

Added new patch set.

http://codereview.chromium.org/7976003/diff/1/src/spaces.cc
File src/spaces.cc (right):

http://codereview.chromium.org/7976003/diff/1/src/spaces.cc#newcode950
src/spaces.cc:950: from_space_.Reset();
On 2011/09/20 13:28:38, Lasse Reichstein wrote:
> Could you change "from space" to "from-space" in the comments? Ditto for "to
> space"? It's more readable. 

Done.

Expand Messages | Collapse Messages

Issue 7976003: Fix new space shrinking to reset from-space. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Lasse Reichstein. #

Messages