Break large blobs into multiple ipcs during creation.

content/browser/renderer_host/blob_message_filter.h

Index: content/browser/renderer_host/blob_message_filter.h
===================================================================
--- content/browser/renderer_host/blob_message_filter.h	(revision 102191)
+++ content/browser/renderer_host/blob_message_filter.h	(working copy)
@@ -7,6 +7,7 @@
 
 #include "base/hash_tables.h"
 #include "content/browser/browser_message_filter.h"
+#include "webkit/blob/blob_data.h"
 
 class ChromeBlobStorageContext;
 class GURL;
@@ -15,10 +16,6 @@
 class Message;
 }
 
-namespace webkit_blob {
-class BlobData;
-}
-
 class BlobMessageFilter : public BrowserMessageFilter {
  public:
   BlobMessageFilter(int process_id,
@@ -31,13 +28,13 @@
                                  bool* message_was_ok);
 
  private:
-  void OnRegisterBlobUrl(const GURL& url,
-                         const scoped_refptr<webkit_blob::BlobData>& blob_data);
+  void OnRegisterUnfinalizedBlobUrl(const GURL& url);

[jianli, 2011/09/23 23:00:42]

It would be more intuitive to name the message as
BlobHostMsg_StartBuildingBlob.

[michaeln, 2011/09/24 01:15:24]

That would make sense so long as we change the terminology throughout to be
consistent. How's this...

StartBuildingBlob  // replaces Register (along with the next two)
AppendBlobDataItem
FinishBuildingBlob
CloneBlob  // replaces RegisterFromOther
RemoveBlob // replaces Unregister

[jianli, 2011/09/27 01:12:18]

Sounds good to me.

[michaeln, 2011/09/27 23:27:31]

Done.

+  void OnAppendBlobDataItem(const GURL& url,
+                            const webkit_blob::BlobData::Item& item);
+  void OnFinalizeBlob(const GURL& url, const std::string& content_type);
   void OnRegisterBlobUrlFrom(const GURL& url, const GURL& src_url);
   void OnUnregisterBlobUrl(const GURL& url);
 
-  bool CheckPermission(webkit_blob::BlobData* blob_data) const;
-
   int process_id_;
   scoped_refptr<ChromeBlobStorageContext> blob_storage_context_;