Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: src/hydrogen.h

Issue 7974009: Fix a bug with uninitialized const variables in the optimizing compiler. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 void EliminateRedundantPhis(); 236 void EliminateRedundantPhis();
237 void EliminateUnreachablePhis(); 237 void EliminateUnreachablePhis();
238 void Canonicalize(); 238 void Canonicalize();
239 void OrderBlocks(); 239 void OrderBlocks();
240 void AssignDominators(); 240 void AssignDominators();
241 void ReplaceCheckedValues(); 241 void ReplaceCheckedValues();
242 void PropagateDeoptimizingMark(); 242 void PropagateDeoptimizingMark();
243 243
244 // Returns false if there are phi-uses of the arguments-object 244 // Returns false if there are phi-uses of the arguments-object
245 // which are not supported by the optimizing compiler. 245 // which are not supported by the optimizing compiler.
246 bool CheckPhis(); 246 bool CheckArgumentsPhiUses();
247 247
248 // Returns false if there are phi-uses of hole values comming 248 // Returns false if there are phi-uses of an uninitialized const
249 // from uninitialized consts. 249 // which are not supported by the optimizing compiler.
250 bool CollectPhis(); 250 bool CheckConstPhiUses();
251
252 void CollectPhis();
251 253
252 Handle<Code> Compile(CompilationInfo* info); 254 Handle<Code> Compile(CompilationInfo* info);
253 255
254 void set_undefined_constant(HConstant* constant) { 256 void set_undefined_constant(HConstant* constant) {
255 undefined_constant_.set(constant); 257 undefined_constant_.set(constant);
256 } 258 }
257 HConstant* GetConstantUndefined() const { return undefined_constant_.get(); } 259 HConstant* GetConstantUndefined() const { return undefined_constant_.get(); }
258 HConstant* GetConstant1(); 260 HConstant* GetConstant1();
259 HConstant* GetConstantMinus1(); 261 HConstant* GetConstantMinus1();
260 HConstant* GetConstantTrue(); 262 HConstant* GetConstantTrue();
(...skipping 973 matching lines...) Expand 10 before | Expand all | Expand 10 after
1234 const char* filename_; 1236 const char* filename_;
1235 HeapStringAllocator string_allocator_; 1237 HeapStringAllocator string_allocator_;
1236 StringStream trace_; 1238 StringStream trace_;
1237 int indent_; 1239 int indent_;
1238 }; 1240 };
1239 1241
1240 1242
1241 } } // namespace v8::internal 1243 } } // namespace v8::internal
1242 1244
1243 #endif // V8_HYDROGEN_H_ 1245 #endif // V8_HYDROGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698