Issue 7973006: Make isimpledom write shared generated files to SHARED_INTERMEDIATE_DIR

Issue 7973006: Make isimpledom write shared generated files to SHARED_INTERMEDIATE_DIR (Closed)

Created:
9 years, 3 months ago by Ryan Sleevi

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, dmazzoni, sky

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, jam, dpranke+watch-content_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., ctguil+watch_chromium.org, zork+watch_chromium.org, Evan Martin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make isimpledom write shared generated files to SHARED_INTERMEDIATE_DIR BUG=97186 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102254

Patch Set 1 #

Patch Set 2 : Cleanup the GYP #

Total comments: 2

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -22 lines)			Patch
M	chrome/browser/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/accessibility/accessibility_win_browsertest.cc	View		1 chunk	+1 line, -1 line	2 comments	Download
M	content/browser/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/accessibility/browser_accessibility_win.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	third_party/isimpledom/isimpledom.gyp	View	1	1 chunk	+11 lines, -18 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

Dominic, one more CL. Builds on http://codereview.chromium.org/7971008/ to reduce the conflicts. Evan, another FYI in ...

9 years, 3 months ago (2011-09-20 08:19:53 UTC) #1

dmazzoni

lgtm http://codereview.chromium.org/7973006/diff/2001/chrome/browser/accessibility/accessibility_win_browsertest.cc File chrome/browser/accessibility/accessibility_win_browsertest.cc (right): http://codereview.chromium.org/7973006/diff/2001/chrome/browser/accessibility/accessibility_win_browsertest.cc#newcode22 chrome/browser/accessibility/accessibility_win_browsertest.cc:22: #include "third_party/isimpledom/ISimpleDOMNode.h" NOLINT isn't needed for this one? ...

9 years, 3 months ago (2011-09-20 13:01:22 UTC) #2

Ryan Sleevi

sky: content/browser/ rubber-stamp? http://codereview.chromium.org/7973006/diff/2001/chrome/browser/accessibility/accessibility_win_browsertest.cc File chrome/browser/accessibility/accessibility_win_browsertest.cc (right): http://codereview.chromium.org/7973006/diff/2001/chrome/browser/accessibility/accessibility_win_browsertest.cc#newcode22 chrome/browser/accessibility/accessibility_win_browsertest.cc:22: #include "third_party/isimpledom/ISimpleDOMNode.h" On 2011/09/20 13:01:22, Dominic ...

9 years, 3 months ago (2011-09-21 02:08:09 UTC) #3

commit-bot: I haz the power

Can't apply patch for file chrome/browser/accessibility/accessibility_win_browsertest.cc. While running patch -p1 --forward --force; patching file chrome/browser/accessibility/accessibility_win_browsertest.cc ...

9 years, 3 months ago (2011-09-22 03:45:18 UTC) #5

Change committed as 102254

Expand Messages | Collapse Messages