Making TOOLKIT_USES_GTK orthogonal to USE_AURA.

Making TOOLKIT_USES_GTK orthogonal to USE_AURA.


BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102019

[Emmanuel Saint-loubert-Bié, 2011-09-20 01:37:18]

As discussed this makes TOOLKIT_USES_GTK and USE_AURA exclusive.
No more GTK in Aura. Yeah!

-- Emmanuel

[sadrul, 2011-09-20 18:35:56]

Looks good. For the change in common.gypi: I think either this CL needs to bring
in the changes made in http://codereview.chromium.org/7904034/, or this should
remove the change in common.gypi and go in after that CL.

For the changes in chrome_browser and content_browser .gypi files: those rules
are not necessary anymore because there's a rule that excludes all _gtk.* files
when toolkit_uses_gtk is set to 0, right? Very nice.

http://codereview.chromium.org/7973003/diff/3001/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7973003/diff/3001/build/common.gypi#newcode245
build/common.gypi:245: }, {
I think this needs to have some more change
(http://codereview.chromium.org/7904034/)

[Emmanuel Saint-loubert-Bié, 2011-09-20 20:08:30]

Sadrul! Thanks I will rebase this CL on top of
http://codereview.chromium.org/7904034/ and land after that one.

Is it LGTM'ed otherwise?

[sadrul, 2011-09-20 20:31:09]

Yep. LGTM

[sadrul, 2011-09-20 20:33:38]

I just landed http://codereview.chromium.org/7904034/