Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: content/renderer/content_renderer_client.h

Issue 7972018: Don't depend on the embedder creating a plugin. That way embedders can always provide an empty Co... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | content/renderer/mock_content_renderer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/content_renderer_client.h
===================================================================
--- content/renderer/content_renderer_client.h (revision 102285)
+++ content/renderer/content_renderer_client.h (working copy)
@@ -53,12 +53,14 @@
// Returns the default text encoding.
virtual std::string GetDefaultEncoding() = 0;
- // Create a plugin in the given frame. Can return NULL, in which case
- // RenderView will create a plugin itself.
- virtual WebKit::WebPlugin* CreatePlugin(
+ // Allows the embedder to override creating a plugin. If it returns true, then
+ // |plugin| will contain the created plugin, although it could be NULL. If it
+ // returns false, the content layer will create the plugin.
+ virtual bool OverrideCreatePlugin(
RenderView* render_view,
WebKit::WebFrame* frame,
- const WebKit::WebPluginParams& params) = 0;
+ const WebKit::WebPluginParams& params,
+ WebKit::WebPlugin** plugin) = 0;
// Give the embedder the ability to set an error page.
virtual void ShowErrorPage(RenderView* render_view,
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | content/renderer/mock_content_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698