chrome/browser/policy/config_dir_policy_provider_unittest.cc - Issue 7972013: ConfigurationPolicyPrefStore refactoring to surface error messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/config_dir_policy_provider_unittest.cc

Issue 7972013: ConfigurationPolicyPrefStore refactoring to surface error messages. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: . Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/browser_policy_connector.cc ('k') | chrome/browser/policy/configuration_policy_handler.h » ('j') | chrome/browser/policy/configuration_policy_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/config_dir_policy_provider_unittest.cc

diff --git a/chrome/browser/policy/config_dir_policy_provider_unittest.cc b/chrome/browser/policy/config_dir_policy_provider_unittest.cc

index 0b3b32c466f075d37bde5b51ff2eec7f02069a7d..878d2a297fcf15129c5a91780e4df69c25a8048c 100644

--- a/chrome/browser/policy/config_dir_policy_provider_unittest.cc

+++ b/chrome/browser/policy/config_dir_policy_provider_unittest.cc

@@ -193,18 +193,6 @@ TEST_P(ConfigDirPolicyProviderValueTest, Default) {

EXPECT_TRUE(policy_map.empty());

}

-TEST_P(ConfigDirPolicyProviderValueTest, NullValue) {

- DictionaryValue dict;

- dict.Set(GetParam().policy_key(), Value::CreateNullValue());

- WriteConfigFile(dict, "empty");

- ConfigDirPolicyProvider provider(

- ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(),

- test_dir());

- PolicyMap policy_map;

- EXPECT_TRUE(provider.Provide(&policy_map));

- EXPECT_TRUE(policy_map.empty());

TEST_P(ConfigDirPolicyProviderValueTest, TestValue) {

DictionaryValue dict;

dict.Set(GetParam().policy_key(), GetParam().test_value()->DeepCopy());