Fix checking default protocol client on Linux

Fix checking default protocol client on Linux

When getting the default protocol client using the system xdg-settings tool
fails, Chrome tries to use its own. The constant script name it looked for
was mistyped (as xdg_settings) which meant this would always fail.

This code path is not currently used by Chrome but will be soon.

TEST=Check setting Chrome as default browser on Linux works; check registering
     Chrome to handle protocols works.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102079

[benwells, 2011-09-20 06:54:13]

While here I added a couple of other constants for other string literals used in
multiple places with xdg-settings.

[Evan Martin, 2011-09-20 14:45:51]

LGTM

http://codereview.chromium.org/7972011/diff/1/chrome/browser/shell_integratio...
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/7972011/diff/1/chrome/browser/shell_integratio...
chrome/browser/shell_integration_linux.cc:229: const char*
kXdgSettingsDefaultSchemeHandler = "default-url-scheme-handler";
Minor nit: can you make these const char[] instead?

(Difference is that the existing code writes out the array and the pointer as
two variables, while const char[] writes out just the array.)

[Evan Martin, 2011-09-20 14:47:17]

LGTM

[benwells, 2011-09-20 23:09:02]

Nit addressed; will commit.

http://codereview.chromium.org/7972011/diff/1/chrome/browser/shell_integratio...
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/7972011/diff/1/chrome/browser/shell_integratio...
chrome/browser/shell_integration_linux.cc:229: const char*
kXdgSettingsDefaultSchemeHandler = "default-url-scheme-handler";
On 2011/09/20 14:45:51, Evan Martin wrote:
> Minor nit: can you make these const char[] instead?
> 
> (Difference is that the existing code writes out the array and the pointer as
> two variables, while const char[] writes out just the array.)

Done.

[commit-bot: I haz the power, 2011-09-21 03:08:47]

Change committed as 102079

[Mike Mammarella, 2011-09-21 07:05:01]

(late) LGTM