Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 7971008: Make iaccessible2 write shared generated files to SHARED_INTERMEDIATE_DIR (Closed)

Created:
9 years, 3 months ago by Ryan Sleevi
Modified:
9 years, 3 months ago
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, jam, amit, dpranke+watch-content_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., ctguil+watch_chromium.org, zork+watch_chromium.org, Evan Martin
Visibility:
Public.

Description

Make iaccessible2 write shared generated files to SHARED_INTERMEDIATE_DIR BUG=97186 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102247

Patch Set 1 #

Patch Set 2 : Sort headers and NOLINT #

Patch Set 3 : Fix check_deps #

Patch Set 4 : Update GYP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M chrome/browser/DEPS View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/chrome_frame_ui_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/iaccessible2/iaccessible2.gyp View 1 2 3 3 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Sleevi
scottmg: You were the most recent to touch the files, would you be capable of ...
9 years, 3 months ago (2011-09-20 05:34:01 UTC) #1
dmazzoni
LGTM!!! Thanks, I knew this was ugly back when I added iaccessible2 and isimpledom but ...
9 years, 3 months ago (2011-09-20 06:40:23 UTC) #2
commit-bot: I haz the power
Presubmit check for 7971008-5001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 3 months ago (2011-09-21 02:04:48 UTC) #3
Ryan Sleevi
sky: content/browser rubber-stamp?
9 years, 3 months ago (2011-09-21 02:06:48 UTC) #4
sky
LGTM
9 years, 3 months ago (2011-09-22 03:47:07 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-09-22 06:18:27 UTC) #6
Change committed as 102247

Powered by Google App Engine
This is Rietveld 408576698