Issue 7970018: sync: we can't lookup empty client tag nodes, so don't allow creating them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7970018: sync: we can't lookup empty client tag nodes, so don't allow creating them (Closed)

Created:
9 years, 3 months ago by tim (not reviewing)

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

sync: we can't lookup empty client tag nodes, so don't allow creating them BUG=none TEST=SyncApiTest.EmptyTags Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102432

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	chrome/browser/sync/internal_api/syncapi_unittest.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
	M	chrome/browser/sync/internal_api/write_node.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/7970018/1

9 years, 3 months ago (2011-09-22 22:53:14 UTC) #3

Change committed as 102432