Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: src/incremental-marking.h

Issue 7970009: Merged from GC branch to bleeding_edge (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Updated test expectations. More passes, but not all. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/incremental-marking.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/incremental-marking.h
diff --git a/src/incremental-marking.h b/src/incremental-marking.h
index 34fe0bbb2c2dc07cbef802e325397c77275e810e..cd1a41142107b22e36012739ab6651f53b594f00 100644
--- a/src/incremental-marking.h
+++ b/src/incremental-marking.h
@@ -138,13 +138,16 @@ class IncrementalMarking {
inline void WhiteToGrey(HeapObject* obj, MarkBit mark_bit);
- // Does white->black or grey->grey
+ // Does white->black or keeps gray or black color. Returns true if converting
+ // white to black.
inline bool MarkBlackOrKeepGrey(MarkBit mark_bit) {
ASSERT(!Marking::IsImpossible(mark_bit));
- if (mark_bit.Get()) return false;
+ if (mark_bit.Get()) {
+ // Grey or black: Keep the color.
+ return false;
+ }
mark_bit.Set();
- ASSERT(!Marking::IsWhite(mark_bit));
- ASSERT(!Marking::IsImpossible(mark_bit));
+ ASSERT(Marking::IsBlack(mark_bit));
return true;
}
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/incremental-marking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698