Issue 7970009: Merged from GC branch to bleeding_edge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7970009: Merged from GC branch to bleeding_edge (Closed)

Created:
9 years, 3 months ago by Lasse Reichstein

Modified:
9 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev, Michael Starzinger

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix calculation of live-bytes in pages. The "live bytes" count is *really* a "marked black" count - i.e., the count of bytes *known* to be live. Fix aggravating bug on X64 where assembler code used a value that was off by a factor of 2^31. Ensure that sweeping clears live-bytes. Added other missing increments. Added print statements to trace live-byte modifications, under a flag. Still a few cases of undercounting left. (New issue to merge from GC branch to bleeding_edge) Committed: http://code.google.com/p/v8/source/detail?r=9338

Patch Set 1 #

Patch Set 2 : Updated test expectations. More passes, but not all. #

Created: 9 years, 3 months ago

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -25 lines)
M	src/flag-definitions.h	View	1 chunk	+3 lines, -0 lines	0 comments
M	src/ia32/macro-assembler-ia32.cc	View	2 chunks	+6 lines, -1 line	0 comments
M	src/incremental-marking.h	View	1 chunk	+7 lines, -4 lines	0 comments
M	src/incremental-marking.cc	View	2 chunks	+13 lines, -2 lines	0 comments
M	src/incremental-marking-inl.h	View	1 chunk	+3 lines, -1 line	0 comments
M	src/mark-compact.h	View	1 chunk	+2 lines, -0 lines	0 comments
M	src/mark-compact.cc	View	8 chunks	+11 lines, -4 lines	0 comments
M	src/spaces.h	View	3 chunks	+24 lines, -4 lines	0 comments
M	src/spaces.cc	View	3 chunks	+28 lines, -2 lines	0 comments
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+1 line, -1 line	0 comments
M	test/mjsunit/mjsunit.status	View	1 chunk	+1 line, -6 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 3 months ago (2011-09-20 10:43:18 UTC) #2

lgtm

please try to reenable tests in mjsunit.status

Expand Messages | Collapse Messages