Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 7970009: Merged from GC branch to bleeding_edge (Closed)

Created:
9 years, 3 months ago by Lasse Reichstein
Modified:
9 years, 3 months ago
CC:
v8-dev, Michael Starzinger
Visibility:
Public.

Description

Fix calculation of live-bytes in pages. The "live bytes" count is *really* a "marked black" count - i.e., the count of bytes *known* to be live. Fix aggravating bug on X64 where assembler code used a value that was off by a factor of 2^31. Ensure that sweeping clears live-bytes. Added other missing increments. Added print statements to trace live-byte modifications, under a flag. Still a few cases of undercounting left. (New issue to merge from GC branch to bleeding_edge) Committed: http://code.google.com/p/v8/source/detail?r=9338

Patch Set 1 #

Patch Set 2 : Updated test expectations. More passes, but not all. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -25 lines) Patch
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/incremental-marking.h View 1 chunk +7 lines, -4 lines 0 comments Download
M src/incremental-marking.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M src/incremental-marking-inl.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/mark-compact.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mark-compact.cc View 8 chunks +11 lines, -4 lines 0 comments Download
M src/spaces.h View 3 chunks +24 lines, -4 lines 0 comments Download
M src/spaces.cc View 3 chunks +28 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
PTAL
9 years, 3 months ago (2011-09-20 09:40:22 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-09-20 10:43:18 UTC) #2
lgtm

please try to reenable tests in mjsunit.status

Powered by Google App Engine
This is Rietveld 408576698