Issue 7969027: ntp4: drag from bookmark page to apps page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7969027: ntp4: drag from bookmark page to apps page (Closed)

Created:
9 years, 3 months ago by Evan Stade

Modified:
9 years, 3 months ago

Reviewers:
csilv, Dan Beam (Google), Dan Beam

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp4: drag from bookmark page to apps page BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102424

Patch Set 3 : disallow folder drags #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/browser/resources/ntp4/apps_page.js	View	1 2	2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

http://codereview.chromium.org/7969027/diff/1/chrome/browser/resources/ntp4/apps_page.js File chrome/browser/resources/ntp4/apps_page.js (right): http://codereview.chromium.org/7969027/diff/1/chrome/browser/resources/ntp4/apps_page.js#newcode646 chrome/browser/resources/ntp4/apps_page.js:646: currentlyDraggingTile.querySelector('.bookmark')) { like we talked about on chat, might ...

9 years, 3 months ago (2011-09-22 22:36:01 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 7969027: ntp4: drag from bookmark page to apps page (Closed)

Description

Patch Set 1 #

Patch Set 2 : one selector #

Patch Set 3 : disallow folder drags #

Messages