Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: content/browser/tab_contents/navigation_entry_unittest.cc

Issue 7969023: For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. Th... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/navigation_entry_unittest.cc
===================================================================
--- content/browser/tab_contents/navigation_entry_unittest.cc (revision 102325)
+++ content/browser/tab_contents/navigation_entry_unittest.cc (working copy)
@@ -105,7 +105,7 @@
EXPECT_EQ(SECURITY_STYLE_UNKNOWN, entry1_.get()->ssl().security_style());
EXPECT_EQ(SECURITY_STYLE_UNKNOWN, entry2_.get()->ssl().security_style());
EXPECT_EQ(0, entry1_.get()->ssl().cert_id());
- EXPECT_EQ(0, entry1_.get()->ssl().cert_status());
+ EXPECT_EQ(0U, entry1_.get()->ssl().cert_status());
EXPECT_EQ(-1, entry1_.get()->ssl().security_bits());
EXPECT_FALSE(entry1_.get()->ssl().displayed_insecure_content());
EXPECT_FALSE(entry1_.get()->ssl().ran_insecure_content());
@@ -113,13 +113,14 @@
// Change from the defaults
entry2_.get()->ssl().set_security_style(SECURITY_STYLE_AUTHENTICATED);
entry2_.get()->ssl().set_cert_id(4);
- entry2_.get()->ssl().set_cert_status(1);
+ entry2_.get()->ssl().set_cert_status(net::CERT_STATUS_COMMON_NAME_INVALID);
entry2_.get()->ssl().set_security_bits(0);
entry2_.get()->ssl().set_displayed_insecure_content();
EXPECT_EQ(SECURITY_STYLE_AUTHENTICATED,
entry2_.get()->ssl().security_style());
EXPECT_EQ(4, entry2_.get()->ssl().cert_id());
- EXPECT_EQ(1, entry2_.get()->ssl().cert_status());
+ EXPECT_EQ(net::CERT_STATUS_COMMON_NAME_INVALID,
+ entry2_.get()->ssl().cert_status());
EXPECT_EQ(0, entry2_.get()->ssl().security_bits());
EXPECT_TRUE(entry2_.get()->ssl().displayed_insecure_content());
« no previous file with comments | « content/browser/tab_contents/navigation_entry.h ('k') | content/browser/tab_contents/provisional_load_details.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698