Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6809)

Unified Diff: chrome/browser/ssl/ssl_error_info.h

Issue 7969023: For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. Th... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | chrome/browser/ssl/ssl_error_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_error_info.h
===================================================================
--- chrome/browser/ssl/ssl_error_info.h (revision 102325)
+++ chrome/browser/ssl/ssl_error_info.h (working copy)
@@ -10,6 +10,7 @@
#include <vector>
#include "base/string16.h"
+#include "net/base/cert_status_flags.h"
#include "net/base/x509_certificate.h"
class GURL;
@@ -46,9 +47,10 @@
// Populates the specified |errors| vector with the errors contained in
// |cert_status|. Returns the number of errors found.
// Callers only interested in the error count can pass NULL for |errors|.
- static int GetErrorsForCertStatus(int cert_status,
- int cert_id,
- const GURL& request_url,
+ // TODO(wtc): Document |cert_id| and |url| arguments.
+ static int GetErrorsForCertStatus(int cert_id,
+ net::CertStatus cert_status,
+ const GURL& url,
std::vector<SSLErrorInfo>* errors);
// A title describing the error, usually to be used with the details below.
« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | chrome/browser/ssl/ssl_error_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698