Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7969020: presubmit - don't check test functions for wstring (Closed)

Created:
9 years, 3 months ago by Evan Stade
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

presubmit - don't check test functions for wstring BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102438

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M PRESUBMIT.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
9 years, 3 months ago (2011-09-22 20:16:52 UTC) #1
M-A Ruel
lgtm, but I'd like EvanM opinion too.
9 years, 3 months ago (2011-09-22 20:19:08 UTC) #2
Evan Martin
LGTM. Maybe use '_test.cc' instead. On Thu, Sep 22, 2011 at 1:19 PM, <maruel@chromium.org> wrote: ...
9 years, 3 months ago (2011-09-22 20:33:51 UTC) #3
Evan Stade
On Thu, Sep 22, 2011 at 1:33 PM, Evan Martin <evan@chromium.org> wrote: > LGTM. Maybe ...
9 years, 3 months ago (2011-09-22 20:50:56 UTC) #4
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/7969020/2001
9 years, 3 months ago (2011-09-23 02:09:09 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-09-23 03:37:54 UTC) #6 
Change committed as 102438

Powered by Google App Engine
This is Rietveld 408576698