Issue 7969009: Removed chromeos::NetworkStateNotifier and redirected all related code to use

Issue 7969009: Removed chromeos::NetworkStateNotifier and redirected all related code to use (Closed)

Created:
9 years, 3 months ago by zel

Modified:
9 years, 3 months ago

Reviewers:
xiyuan, oshima

CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, kkania, davemoore+watch_chromium.org, stevenjb, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Removed chromeos::NetworkStateNotifier and redirected all related code to use net::NetworkChangeNotifier instead. BUG=chromium-os:20014 TEST=make sure hosted app loading is still respecting network online state changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102209

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -400 lines)			Patch
M	chrome/browser/automation/testing_automation_provider_chromeos.cc	View	1 2 3 4 5 6	3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/boot_times_loader.cc	View	1 2 3 4 5 6	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/net/network_change_notifier_chromeos.cc	View	1 2 3 4 5 6	2 chunks	+5 lines, -2 lines	0 comments	Download
D	chrome/browser/chromeos/network_state_notifier.h	View	1 2 3 4 5 6	1 chunk	+0 lines, -92 lines	0 comments	Download
D	chrome/browser/chromeos/network_state_notifier.cc	View	1 2 3 4 5 6	1 chunk	+0 lines, -93 lines	0 comments	Download
D	chrome/browser/chromeos/network_state_notifier_browsertest.cc	View	1 2 3 4 5 6	1 chunk	+0 lines, -115 lines	0 comments	Download
M	chrome/browser/chromeos/offline/offline_load_page.h	View	1 2 3 4 5 6	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/offline/offline_load_page.cc	View	1 2 3 4 5 6	3 chunks	+13 lines, -24 lines	0 comments	Download
M	chrome/browser/chromeos/web_socket_proxy_controller.cc	View	1 2 3 4 5 6	2 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/browser/renderer_host/offline_resource_handler.cc	View	1 2 3 4 5 6	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sessions/session_restore.cc	View	1 2 3 4 5 6	7 chunks	+22 lines, -33 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View	1 2 3 4 5 6	2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4 5 6	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5 6	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_notification_types.h	View	1 2 3 4 5 6	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

oshima

http://codereview.chromium.org/7969009/diff/1/chrome/browser/chromeos/offline/offline_load_page.cc File chrome/browser/chromeos/offline/offline_load_page.cc (right): http://codereview.chromium.org/7969009/diff/1/chrome/browser/chromeos/offline/offline_load_page.cc#newcode205 chrome/browser/chromeos/offline/offline_load_page.cc:205: Proceed(); Will NSNotificer use UI thread to invoke this? ...

9 years, 3 months ago (2011-09-20 01:38:28 UTC) #2

xiyuan

LGTM network_state_notifier_browsertest.cc probably should be removed too as Oshima suggested. http://codereview.chromium.org/7969009/diff/1/chrome/browser/chromeos/offline/offline_load_page.h File chrome/browser/chromeos/offline/offline_load_page.h (right): http://codereview.chromium.org/7969009/diff/1/chrome/browser/chromeos/offline/offline_load_page.h#newcode67 ...

9 years, 3 months ago (2011-09-20 04:20:37 UTC) #3

zel

9 years, 3 months ago (2011-09-20 15:27:40 UTC) #4

zel

http://codereview.chromium.org/7969009/diff/1/chrome/browser/chromeos/offline/offline_load_page.h File chrome/browser/chromeos/offline/offline_load_page.h (right): http://codereview.chromium.org/7969009/diff/1/chrome/browser/chromeos/offline/offline_load_page.h#newcode67 chrome/browser/chromeos/offline/offline_load_page.h:67: virtual void OnOnlineStateChanged(bool online); On 2011/09/20 04:20:37, xiyuan wrote: ...

9 years, 3 months ago (2011-09-20 15:27:56 UTC) #5

LGTM

Expand Messages | Collapse Messages