Get url_request_unittest.cc to build on Linux.

Get url_request_unittest.cc to build on Linux.
See http://code.google.com/p/chromium/issues/detail?id=3661

Also change LaunchApp to check PATH, 
and fixed a useful gcc-4.3 warning re operator precedence.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4515

[Jo, 2008-10-24 03:31:44]

http://codereview.chromium.org/7968/diff/1/2
File net/net_unittests.scons (right):

http://codereview.chromium.org/7968/diff/1/2#newcode95
Line 95: 'http/http_transaction_unittest.cc',
[bad sorting] this line have to come after the next one.

http://codereview.chromium.org/7968/diff/1/2#newcode103
Line 103: if env['PLATFORM'] == 'win32':
While modifying this file, you could add this comment or something similar to
tell exactly why we have a "if env['PLATFORM'] == 'win32'":
# TODO(port): These extra files aren't win32-specific, they've just not been
# tested on other platforms yet.

http://codereview.chromium.org/7968/diff/1/2#newcode112
Line 112: 'http/http_network_transaction_unittest.cc',
You forgot to remove this test in this list.

http://codereview.chromium.org/7968/diff/1/2#newcode113
Line 113: 'http/http_transaction_unittest.cc',
You forgot to remove this test too.

[dank, 2008-11-03 22:19:43]

Nothing special, just enabling part of one more unit test.

Wait, there is something special: the test will fail
unless you install tlslite from third_party.  
The error message when it fails tells you how.
Presumably if this patch makes it in we would update
our build doc.

[agl, 2008-11-03 22:34:31]

http://codereview.chromium.org/7968/diff/401/602
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/7968/diff/401/602#newcode357
Line 357: LOG(ERROR) << "port me";
We have a NOTIMPLEMENTED macro for these sorts of things.

http://codereview.chromium.org/7968/diff/401/603
File net/url_request/url_request_unittest.h (right):

http://codereview.chromium.org/7968/diff/401/603#newcode299
Line 299: FILE *fp = fopen("/usr/bin/tls.py", "r");
This should be access("/usr/bin/tls.py", X_OK);

http://codereview.chromium.org/7968/diff/401/603#newcode305
Line 305: command_line.push_back("/usr/bin/python");
Can we use env here to remove the hardcoded path?

http://codereview.chromium.org/7968/diff/401/603#newcode310
Line 310: command_line.push_back("--https=\"" + WideToUTF8(cert_path) + "\"");
I don't think we want the quotes here. LaunchApp uses execv to exec and so the
arguments aren't going to get processed by any shells.

[agl, 2008-11-03 23:16:53]

LGTM