chrome/browser/ui/webui/options/autofill_options_handler.cc - Issue 7967024: Profile shouldn't own PersonalDataManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/autofill_options_handler.cc

Issue 7967024: Profile shouldn't own PersonalDataManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addresses isherman #11 Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/autofill_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/autofill_options_handler.cc b/chrome/browser/ui/webui/options/autofill_options_handler.cc

index e56352b0a6108c0048ebf875e087032485fb2756..dba5519d4886f0a9847f738d28b7f33412abd20f 100644

--- a/chrome/browser/ui/webui/options/autofill_options_handler.cc

+++ b/chrome/browser/ui/webui/options/autofill_options_handler.cc

@@ -15,6 +15,7 @@

#include "chrome/browser/autofill/autofill_profile.h"

#include "chrome/browser/autofill/credit_card.h"

#include "chrome/browser/autofill/personal_data_manager.h"

+#include "chrome/browser/autofill/personal_data_manager_factory.h"

#include "chrome/browser/autofill/phone_number_i18n.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/webui/web_ui_util.h"

@@ -225,7 +226,8 @@ void AutofillOptionsHandler::GetLocalizedValues(

}

void AutofillOptionsHandler::Initialize() {

- personal_data_ = Profile::FromWebUI(web_ui_)->GetPersonalDataManager();

+ personal_data_ = PersonalDataManagerFactory::GetForProfile(

+ Profile::FromWebUI(web_ui_));

personal_data_->SetObserver(this);

LoadAutofillData();