chrome/browser/browsing_data_remover.cc - Issue 7967024: Profile shouldn't own PersonalDataManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data_remover.cc

Issue 7967024: Profile shouldn't own PersonalDataManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addresses isherman #11 Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browsing_data_remover.cc

diff --git a/chrome/browser/browsing_data_remover.cc b/chrome/browser/browsing_data_remover.cc

index 271fdd38fd1dbea368a0d236cde7994ada262895..3a6f91d0739e84a07ae62b816fb93584013d6f6e 100644

--- a/chrome/browser/browsing_data_remover.cc

+++ b/chrome/browser/browsing_data_remover.cc

@@ -13,6 +13,7 @@

#include "base/logging.h"

#include "base/platform_file.h"

#include "chrome/browser/autofill/personal_data_manager.h"

+#include "chrome/browser/autofill/personal_data_manager_factory.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_special_storage_policy.h"

@@ -262,7 +263,8 @@ void BrowsingDataRemover::Remove(int remove_mask) {

delete_end_);

web_data_service->RemoveAutofillProfilesAndCreditCardsModifiedBetween(

delete_begin_, delete_end_);

- PersonalDataManager* data_manager = profile_->GetPersonalDataManager();

+ PersonalDataManager* data_manager =

+ PersonalDataManagerFactory::GetForProfile(profile_);

if (data_manager) {

data_manager->Refresh();

}