Profile shouldn't own PersonalDataManager

chrome/browser/autofill/autofill_merge_unittest.cc

Index: chrome/browser/autofill/autofill_merge_unittest.cc
diff --git a/chrome/browser/autofill/autofill_merge_unittest.cc b/chrome/browser/autofill/autofill_merge_unittest.cc
index 6f676d7e7ff71a5ec92ab6146f1ad12e0e104d70..327a2a9dd15120f9ed9f3c5df6ca442519bf6619 100644
--- a/chrome/browser/autofill/autofill_merge_unittest.cc
+++ b/chrome/browser/autofill/autofill_merge_unittest.cc
@@ -128,7 +128,7 @@ class AutofillMergeTest : public testing::Test,
   // sequentially, and fills |merged_profiles| with the serialized result.
   void MergeProfiles(const std::string& profiles, std::string* merged_profiles);
 
-  scoped_refptr<PersonalDataManagerMock> personal_data_;
+  scoped_ptr<PersonalDataManagerMock> personal_data_;

[Ilya Sherman, 2011/09/23 21:41:38]

nit: Can this just be |PersonalDataManagerMock personal_data_|?

[dhollowa, 2011/09/23 22:00:58]

No.  The tests below reset the data with each pass of the data driven test.

[Ilya Sherman, 2011/09/23 22:17:43]

Wait, where does this happen?  If you mean the SetUp() method, I believe that is
exactly equivalent to directly having a PersonalDataManagerMock instance
variable (without the scoped_ptr).

 
  private:
   DISALLOW_COPY_AND_ASSIGN(AutofillMergeTest);
@@ -143,7 +143,7 @@ AutofillMergeTest::~AutofillMergeTest() {
 void AutofillMergeTest::SetUp() {
   autofill_test::DisableSystemServices(NULL);
 
-  personal_data_ = new PersonalDataManagerMock();
+  personal_data_.reset(new PersonalDataManagerMock);
 }
 
 void AutofillMergeTest::GenerateResults(const std::string& input,