Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/autofill/autofill_merge_unittest.cc

Issue 7967024: Profile shouldn't own PersonalDataManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/autofill_manager_unittest.cc ('K') | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/browser/autofill/autofill_metrics_unittest.cc » ('j') | chrome/browser/autofill/personal_data_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_merge_unittest.cc
diff --git a/chrome/browser/autofill/autofill_merge_unittest.cc b/chrome/browser/autofill/autofill_merge_unittest.cc
index 6f676d7e7ff71a5ec92ab6146f1ad12e0e104d70..327a2a9dd15120f9ed9f3c5df6ca442519bf6619 100644
--- a/chrome/browser/autofill/autofill_merge_unittest.cc
+++ b/chrome/browser/autofill/autofill_merge_unittest.cc
@@ -128,7 +128,7 @@ class AutofillMergeTest : public testing::Test,
// sequentially, and fills |merged_profiles| with the serialized result.
void MergeProfiles(const std::string& profiles, std::string* merged_profiles);
- scoped_refptr<PersonalDataManagerMock> personal_data_;
+ scoped_ptr<PersonalDataManagerMock> personal_data_;
private:
DISALLOW_COPY_AND_ASSIGN(AutofillMergeTest);
@@ -143,7 +143,7 @@ AutofillMergeTest::~AutofillMergeTest() {
void AutofillMergeTest::SetUp() {
autofill_test::DisableSystemServices(NULL);
- personal_data_ = new PersonalDataManagerMock();
+ personal_data_.reset(new PersonalDataManagerMock);
}
void AutofillMergeTest::GenerateResults(const std::string& input,
« chrome/browser/autofill/autofill_manager_unittest.cc ('K') | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/browser/autofill/autofill_metrics_unittest.cc » ('j') | chrome/browser/autofill/personal_data_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698