chrome/browser/autofill/autofill_manager.cc - Issue 7967024: Profile shouldn't own PersonalDataManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 7967024: Profile shouldn't own PersonalDataManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autofill/autofill_manager.cc

diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc

index b7eafaf88e1ff63b484a03eb882ef843d30deed4..4558c5ab73eea61b0ff12494bf893dc76cbf1df0 100644

--- a/chrome/browser/autofill/autofill_manager.cc

+++ b/chrome/browser/autofill/autofill_manager.cc

@@ -26,6 +26,7 @@

#include "chrome/browser/autofill/credit_card.h"

#include "chrome/browser/autofill/form_structure.h"

#include "chrome/browser/autofill/personal_data_manager.h"

+#include "chrome/browser/autofill/personal_data_manager_factory.h"

#include "chrome/browser/autofill/phone_number.h"

#include "chrome/browser/autofill/phone_number_i18n.h"

#include "chrome/browser/autofill/select_control_handler.h"

@@ -217,8 +218,8 @@ AutofillManager::AutofillManager(TabContentsWrapper* tab_contents)

DCHECK(tab_contents);

// |personal_data_| is NULL when using TestTabContents.

- personal_data_ =

- tab_contents->profile()->GetOriginalProfile()->GetPersonalDataManager();

+ personal_data_ = PersonalDataManagerFactory::GetForProfile(

+ tab_contents->profile()->GetOriginalProfile());

download_manager_.SetObserver(this);

}