Profile shouldn't own PersonalDataManager

chrome/browser/webdata/web_data_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/webdata/web_data_service.h"
 
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/task.h"
 #include "base/threading/thread.h"
 #include "chrome/browser/autofill/autofill_profile.h"
 #include "chrome/browser/autofill/credit_card.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/ui/profile_error_dialog.h"
 #include "chrome/browser/webdata/autofill_change.h"
 #include "chrome/browser/webdata/autofill_entry.h"
 #include "chrome/browser/webdata/autofill_table.h"
 #include "chrome/browser/webdata/keyword_table.h"
 #include "chrome/browser/webdata/logins_table.h"
 #include "chrome/browser/webdata/token_service_table.h"
 #include "chrome/browser/webdata/web_apps_table.h"
 #include "chrome/browser/webdata/web_intents_table.h"
@@ skipping 12 matching lines @@
 ////////////////////////////////////////////////////////////////////////////////
 //
 // WebDataService implementation.
 //
 ////////////////////////////////////////////////////////////////////////////////
 
 using base::Time;
 using webkit_glue::FormField;
 using webkit_glue::PasswordForm;
 
+namespace {
+// A task used by WebDataService (for Sync mainly) to inform the
+// PersonalDataManager living on the UI thread that it needs to refresh.
+class NotifyOfMultipleAutofillChangesTask : public Task {
+ public:
+  explicit NotifyOfMultipleAutofillChangesTask(
+      WebDataService* web_data_service);
+  virtual ~NotifyOfMultipleAutofillChangesTask();
+  virtual void Run();
+ private:
+  WebDataService* web_data_service_;
+};
+
+NotifyOfMultipleAutofillChangesTask::NotifyOfMultipleAutofillChangesTask(
+    WebDataService* web_data_service) : web_data_service_(web_data_service) {
+}
+
+NotifyOfMultipleAutofillChangesTask::~NotifyOfMultipleAutofillChangesTask() {}
+
+void NotifyOfMultipleAutofillChangesTask::Run() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  NotificationService::current()->Notify(
+      chrome::NOTIFICATION_AUTOFILL_MULTIPLE_CHANGED,
+      Source<WebDataService>(web_data_service_),
+      NotificationService::NoDetails());
+}
+
+}  // namespace
+
 WDAppImagesResult::WDAppImagesResult() : has_all_images(false) {}
 
 WDAppImagesResult::~WDAppImagesResult() {}
 
 WDKeywordsResult::WDKeywordsResult()
   : default_search_provider_id(0),
     builtin_keyword_version(0) {
 }
 
 WDKeywordsResult::~WDKeywordsResult() {}
 
 WebDataService::WebDataService()
   : is_running_(false),
     db_(NULL),
     failed_init_(false),
     should_commit_(false),
     next_request_handle_(1),
     main_loop_(MessageLoop::current()) {
 }
 
+// static
+void WebDataService::NotifyOfMultipleAutofillChanges(Profile* profile) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
+
+  if (!profile)
+    return;
+
+  WebDataService* web_data_service =
+    profile->GetWebDataService(Profile::EXPLICIT_ACCESS);
+  if (!web_data_service)
+    return;
+
+  BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
+      new NotifyOfMultipleAutofillChangesTask(web_data_service));
+}
+
 bool WebDataService::Init(const FilePath& profile_path) {
   FilePath path = profile_path;
   path = path.Append(chrome::kWebDataFilename);
   return InitWithPath(path);
 }
 
 void WebDataService::Shutdown() {
   UnloadDatabase();
 }
 
@@ skipping 1364 matching lines @@
   return result_;
 }
 
 void WebDataService::WebDataRequest::RequestComplete() {
   WebDataService* s = service_;
   Task* t = NewRunnableMethod(s,
                               &WebDataService::RequestCompleted,
                               handle_);
   message_loop_->PostTask(FROM_HERE, t);
 }