Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

Issue 7967024: Profile shouldn't own PersonalDataManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addresses isherman #11 Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h" 5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/i18n/rtl.h" 8 #include "base/i18n/rtl.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "chrome/browser/autofill/autofill_common_test.h" 12 #include "chrome/browser/autofill/autofill_common_test.h"
13 #include "chrome/browser/autofill/autofill_profile.h" 13 #include "chrome/browser/autofill/autofill_profile.h"
14 #include "chrome/browser/autofill/personal_data_manager.h" 14 #include "chrome/browser/autofill/personal_data_manager.h"
15 #include "chrome/browser/autofill/personal_data_manager_factory.h"
15 #include "chrome/browser/history/history.h" 16 #include "chrome/browser/history/history.h"
16 #include "chrome/browser/profiles/profile.h" 17 #include "chrome/browser/profiles/profile.h"
17 #include "chrome/browser/ui/browser.h" 18 #include "chrome/browser/ui/browser.h"
18 #include "chrome/common/url_constants.h" 19 #include "chrome/common/url_constants.h"
19 #include "chrome/test/base/ui_test_utils.h" 20 #include "chrome/test/base/ui_test_utils.h"
20 #include "ui/base/resource/resource_bundle.h" 21 #include "ui/base/resource/resource_bundle.h"
21 22
22 #if defined(OS_POSIX) && defined(TOOLKIT_USES_GTK) 23 #if defined(OS_POSIX) && defined(TOOLKIT_USES_GTK)
23 #include <gtk/gtk.h> 24 #include <gtk/gtk.h>
24 #endif 25 #endif
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 "\xD7\x91\xD7\x93\xD7\x99\xD7\xA7\xD7\x94\x20\xD7\x91\xD7\xA2\xD7\x9E", 218 "\xD7\x91\xD7\x93\xD7\x99\xD7\xA7\xD7\x94\x20\xD7\x91\xD7\xA2\xD7\x9E",
218 "\xD7\x93\xD7\xA8\xD7\x9A\x20\xD7\x9E\xD7\xA0\xD7\x97\xD7\x9D\x20\xD7\x91\ xD7\x92\xD7\x99\xD7\x9F\x20\x32\x33", 219 "\xD7\x93\xD7\xA8\xD7\x9A\x20\xD7\x9E\xD7\xA0\xD7\x97\xD7\x9D\x20\xD7\x91\ xD7\x92\xD7\x99\xD7\x9F\x20\x32\x33",
219 "\xD7\xA7\xD7\x95\xD7\x9E\xD7\x94\x20\x32\x36", 220 "\xD7\xA7\xD7\x95\xD7\x9E\xD7\x94\x20\x32\x36",
220 "\xD7\xAA\xD7\x9C\x20\xD7\x90\xD7\x91\xD7\x99\xD7\x91", 221 "\xD7\xAA\xD7\x9C\x20\xD7\x90\xD7\x91\xD7\x99\xD7\x91",
221 "", 222 "",
222 "66183", 223 "66183",
223 "\xD7\x99\xD7\xA9\xD7\xA8\xD7\x90\xD7\x9C", 224 "\xD7\x99\xD7\xA9\xD7\xA8\xD7\x90\xD7\x9C",
224 "0000"); 225 "0000");
225 226
226 PersonalDataManager* personal_data_manager = 227 PersonalDataManager* personal_data_manager =
227 browser()->profile()->GetPersonalDataManager(); 228 PersonalDataManagerFactory::GetForProfile(browser()->profile());
228 ASSERT_TRUE(personal_data_manager); 229 ASSERT_TRUE(personal_data_manager);
229 230
230 personal_data_manager->AddProfile(profile); 231 personal_data_manager->AddProfile(profile);
231 232
232 RunBidiCheckerOnPage(url.c_str(), false); 233 RunBidiCheckerOnPage(url.c_str(), false);
233 } 234 }
234 235
235 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestFakeBidi, 236 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestFakeBidi,
236 MAYBE_TestSettingsAutofillPageRTL) { 237 MAYBE_TestSettingsAutofillPageRTL) {
237 std::string url(chrome::kChromeUISettingsURL); 238 std::string url(chrome::kChromeUISettingsURL);
(...skipping 10 matching lines...) Expand all
248 "Initech", 249 "Initech",
249 "4120 Freidrich Lane", 250 "4120 Freidrich Lane",
250 "Basement", 251 "Basement",
251 "Austin", 252 "Austin",
252 "Texas", 253 "Texas",
253 "78744", 254 "78744",
254 "United States", 255 "United States",
255 "5125551234"); 256 "5125551234");
256 257
257 PersonalDataManager* personal_data_manager = 258 PersonalDataManager* personal_data_manager =
258 browser()->profile()->GetPersonalDataManager(); 259 PersonalDataManagerFactory::GetForProfile(browser()->profile());
259 ASSERT_TRUE(personal_data_manager); 260 ASSERT_TRUE(personal_data_manager);
260 261
261 personal_data_manager->AddProfile(profile); 262 personal_data_manager->AddProfile(profile);
262 263
263 WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(url.c_str(), true); 264 WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(url.c_str(), true);
264 } 265 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/webui/options/autofill_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698