Profile shouldn't own PersonalDataManager

chrome/browser/profiles/off_the_record_profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/off_the_record_profile_impl.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "build/build_config.h"
+#include "chrome/browser/autofill/personal_data_manager_factory.h"

[Ilya Sherman, 2011/09/23 03:56:34]

nit: What relies on this #include?

[dhollowa, 2011/09/23 16:30:03]

Nothing.  Removed.

 #include "chrome/browser/background/background_contents_service_factory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_plugin_service_filter.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/extensions/extension_info_map.h"
 #include "chrome/browser/extensions/extension_message_service.h"
 #include "chrome/browser/extensions/extension_pref_store.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_special_storage_policy.h"
@@ skipping 306 matching lines @@
     download_manager_delegate_->SetDownloadManager(dlm);
     download_manager_.swap(dlm);
   }
   return download_manager_.get();
 }
 
 bool OffTheRecordProfileImpl::HasCreatedDownloadManager() const {
   return download_manager_.get() != NULL;
 }
 
-PersonalDataManager* OffTheRecordProfileImpl::GetPersonalDataManager() {
-  return NULL;
-}
-
 fileapi::FileSystemContext* OffTheRecordProfileImpl::GetFileSystemContext() {
   CreateQuotaManagerAndClients();
   return file_system_context_.get();
 }
 
 net::URLRequestContextGetter* OffTheRecordProfileImpl::GetRequestContext() {
   return io_data_.GetMainRequestContextGetter();
 }
 
 quota::QuotaManager* OffTheRecordProfileImpl::GetQuotaManager() {
@@ skipping 308 matching lines @@
 
 #if defined(OS_CHROMEOS)
 // Special case of the OffTheRecordProfileImpl which is used while Guest
 // session in CrOS.
 class GuestSessionProfile : public OffTheRecordProfileImpl {
  public:
   explicit GuestSessionProfile(Profile* real_profile)
       : OffTheRecordProfileImpl(real_profile) {
   }
 
-  virtual PersonalDataManager* GetPersonalDataManager() {
-    return GetOriginalProfile()->GetPersonalDataManager();
-  }
-
   virtual void InitChromeOSPreferences() {
     chromeos_preferences_.reset(new chromeos::Preferences());
     chromeos_preferences_->Init(GetPrefs());
   }
 
  private:
   // The guest user should be able to customize Chrome OS preferences.
   scoped_ptr<chromeos::Preferences> chromeos_preferences_;
 };
 #endif
 
 Profile* Profile::CreateOffTheRecordProfile() {
   OffTheRecordProfileImpl* profile = NULL;
 #if defined(OS_CHROMEOS)
   if (Profile::IsGuestSession())
     profile = new GuestSessionProfile(this);
 #endif
   if (!profile)
     profile = new OffTheRecordProfileImpl(this);
   profile->Init();
   return profile;
 }