Profile shouldn't own PersonalDataManager

chrome/browser/autofill/personal_data_manager_factory.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_PERSONAL_DATA_MANAGER_FACTORY_H_
+#define CHROME_BROWSER_AUTOFILL_PERSONAL_DATA_MANAGER_FACTORY_H_
+
+#include "base/compiler_specific.h"
+#include "base/memory/singleton.h"

[tfarina, 2011/09/23 02:30:44]

You can forward declare this instead.

template <typename T> struct DefaultSingletonTraits;

[dhollowa, 2011/09/23 16:30:03]

Done.

+#include "chrome/browser/profiles/profile_keyed_service_factory.h"
+
+class PersonalDataManager;
+class Profile;
+
+// Singleton that owns all PersonalDataManagers and associates them with
+// Profiles.
+// Listens for the Profile's destruction notification and cleans up the
+// associated PersonalDataManager.
+class PersonalDataManagerFactory : public ProfileKeyedServiceFactory {
+ public:
+  // Returns the PersonalDataManager for |profile|, creating it if it is not
+  // yet created.
+  static PersonalDataManager* GetForProfile(Profile* profile);
+
+  static PersonalDataManagerFactory* GetInstance();
+
+ private:
+  friend struct DefaultSingletonTraits<PersonalDataManagerFactory>;
+
+  PersonalDataManagerFactory();
+  virtual ~PersonalDataManagerFactory();
+
+  // ProfileKeyedServiceFactory:
+  virtual ProfileKeyedService* BuildServiceInstanceFor(
+      Profile* profile) const OVERRIDE;
+};
+
+#endif  // CHROME_BROWSER_AUTOFILL_PERSONAL_DATA_MANAGER_FACTORY_H_