Profile shouldn't own PersonalDataManager

chrome/browser/autofill/autofill_metrics_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
-#include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string16.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_cc_infobar_delegate.h"
 #include "chrome/browser/autofill/autofill_common_test.h"
 #include "chrome/browser/autofill/autofill_manager.h"
 #include "chrome/browser/autofill/autofill_metrics.h"
 #include "chrome/browser/autofill/personal_data_manager.h"
+#include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/webdata/web_data_service.h"
 #include "chrome/browser/ui/tab_contents/test_tab_contents_wrapper.h"
+#include "chrome/test/base/testing_profile.h"
 #include "content/browser/browser_thread.h"
 #include "content/browser/tab_contents/test_tab_contents.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/glue/form_data.h"
 #include "webkit/glue/form_field.h"
 
 using ::testing::_;
 using ::testing::AnyNumber;
 using ::testing::Mock;
@@ skipping 45 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(MockAutofillMetrics);
 };
 
 class TestPersonalDataManager : public PersonalDataManager {
  public:
   TestPersonalDataManager() : autofill_enabled_(true) {
     set_metric_logger(new MockAutofillMetrics);
     CreateTestAutofillProfiles(&web_profiles_);
   }
 
+  // Factory method for keyed service.  PersonalDataManager is NULL for testing.
+  static ProfileKeyedService* Build(Profile* profile) {
+    return NULL;
+  }
+
   // Overridden to avoid a trip to the database. This should be a no-op except
   // for the side-effect of logging the profile count.
   virtual void LoadProfiles() OVERRIDE {
     std::vector<AutofillProfile*> profiles;
     web_profiles_.release(&profiles);
     WDResult<std::vector<AutofillProfile*> > result(AUTOFILL_PROFILES_RESULT,
                                                     profiles);
     ReceiveLoadedProfiles(0, &result);
   }
 
@@ skipping 122 matching lines @@
   AutofillMetricsTest();
   virtual ~AutofillMetricsTest();
 
   virtual void SetUp();
 
  protected:
   AutofillCCInfoBarDelegate* CreateDelegate(MockAutofillMetrics* metric_logger,
                                             CreditCard** created_card);
 
   scoped_ptr<TestAutofillManager> autofill_manager_;
-  scoped_refptr<TestPersonalDataManager> test_personal_data_;
+  TestPersonalDataManager personal_data_;
 
  private:
   BrowserThread browser_thread_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillMetricsTest);
 };
 
 AutofillMetricsTest::AutofillMetricsTest()
   : TabContentsWrapperTestHarness(),
     browser_thread_(BrowserThread::UI, &message_loop_) {
 }
 
 AutofillMetricsTest::~AutofillMetricsTest() {
   // Order of destruction is important as AutofillManager relies on
   // PersonalDataManager to be around when it gets destroyed.
   autofill_manager_.reset(NULL);
-  test_personal_data_ = NULL;
 }
 
 void AutofillMetricsTest::SetUp() {
+  Profile* profile = new TestingProfile();
+  browser_context_.reset(profile);
+  PersonalDataManagerFactory::GetInstance()->SetTestingFactory(
+      profile, TestPersonalDataManager::Build);
+
   TabContentsWrapperTestHarness::SetUp();
-  test_personal_data_ = new TestPersonalDataManager();
   autofill_manager_.reset(new TestAutofillManager(contents_wrapper(),
-                                                  test_personal_data_.get()));
+                                                  &personal_data_));
 }
 
 AutofillCCInfoBarDelegate* AutofillMetricsTest::CreateDelegate(
     MockAutofillMetrics* metric_logger,
     CreditCard** created_card) {
   EXPECT_CALL(*metric_logger,
               LogCreditCardInfoBarMetric(AutofillMetrics::INFOBAR_SHOWN));
   // The delegate created below will take ownership of this object.
   CreditCard* credit_card = new CreditCard();
   if (created_card)
     *created_card = credit_card;
   return new AutofillCCInfoBarDelegate(contents(), credit_card,
-      test_personal_data_.get(), metric_logger);
+                                       &personal_data_, metric_logger);
 }
 
 // Test that we log quality metrics appropriately.
 TEST_F(AutofillMetricsTest, QualityMetrics) {
   // Set up our form data.
   FormData form;
   form.name = ASCIIToUTF16("TestForm");
   form.method = ASCIIToUTF16("POST");
   form.origin = GURL("http://example.com/form.html");
   form.action = GURL("http://example.com/submit.html");
@@ skipping 576 matching lines @@
                                        ADDRESS_HOME_COUNTRY, experiment_id));
 
   // Simulate form submission.
   EXPECT_NO_FATAL_FAILURE(autofill_manager_->OnFormSubmitted(form,
                                                              TimeTicks::Now()));
 }
 
 // Test that the profile count is logged correctly.
 TEST_F(AutofillMetricsTest, StoredProfileCount) {
   // The metric should be logged when the profiles are first loaded.
-  EXPECT_CALL(*test_personal_data_->metric_logger(),
+  EXPECT_CALL(*personal_data_.metric_logger(),
               LogStoredProfileCount(2)).Times(1);
-  test_personal_data_->LoadProfiles();
+  personal_data_.LoadProfiles();
 
   // The metric should only be logged once.
-  EXPECT_CALL(*test_personal_data_->metric_logger(),
+  EXPECT_CALL(*personal_data_.metric_logger(),
               LogStoredProfileCount(::testing::_)).Times(0);
-  test_personal_data_->LoadProfiles();
+  personal_data_.LoadProfiles();
 }
 
 // Test that we correctly log whether Autofill is enabled.
 TEST_F(AutofillMetricsTest, AutofillIsEnabledAtStartup) {
-  test_personal_data_->set_autofill_enabled(true);
-  EXPECT_CALL(*test_personal_data_->metric_logger(),
+  personal_data_.set_autofill_enabled(true);
+  EXPECT_CALL(*personal_data_.metric_logger(),
               LogIsAutofillEnabledAtStartup(true)).Times(1);
-  test_personal_data_->Init(NULL);
+  personal_data_.Init(profile());
 
-  test_personal_data_->set_autofill_enabled(false);
-  EXPECT_CALL(*test_personal_data_->metric_logger(),
+  personal_data_.set_autofill_enabled(false);
+  EXPECT_CALL(*personal_data_.metric_logger(),
               LogIsAutofillEnabledAtStartup(false)).Times(1);
-  test_personal_data_->Init(NULL);
+  personal_data_.Init(profile());
 }
 
 // Test that we log the number of Autofill suggestions when filling a form.
 TEST_F(AutofillMetricsTest, AddressSuggestionsCount) {
   // Set up our form data.
   FormData form;
   form.name = ASCIIToUTF16("TestForm");
   form.method = ASCIIToUTF16("POST");
   form.origin = GURL("http://example.com/form.html");
   form.action = GURL("http://example.com/submit.html");
@@ skipping 81 matching lines @@
 // Test that credit card infobar metrics are logged correctly.
 TEST_F(AutofillMetricsTest, CreditCardInfoBar) {
   MockAutofillMetrics metric_logger;
   ::testing::InSequence dummy;
 
   // Accept the infobar.
   {
     CreditCard* credit_card;
     scoped_ptr<InfoBarDelegate> infobar(CreateDelegate(&metric_logger,
                                                        &credit_card));
-    EXPECT_CALL(*test_personal_data_.get(),
-                SaveImportedCreditCard(*credit_card));
+    EXPECT_CALL(personal_data_, SaveImportedCreditCard(*credit_card));
     EXPECT_CALL(metric_logger,
         LogCreditCardInfoBarMetric(AutofillMetrics::INFOBAR_ACCEPTED)).Times(1);
     EXPECT_CALL(metric_logger,
         LogCreditCardInfoBarMetric(AutofillMetrics::INFOBAR_IGNORED)).Times(0);
     EXPECT_TRUE(static_cast<ConfirmInfoBarDelegate*>(infobar.get())->Accept());
   }
 
   // Cancel the infobar.
   {
     scoped_ptr<InfoBarDelegate> infobar(CreateDelegate(&metric_logger, NULL));
@@ skipping 405 matching lines @@
     autofill_manager_->OnTextFieldDidChange(form, form.fields.front(),
                                             TimeTicks::FromInternalValue(3));
     autofill_manager_->OnFormSubmitted(form, TimeTicks::FromInternalValue(17));
     autofill_manager_->Reset();
     Mock::VerifyAndClearExpectations(autofill_manager_->metric_logger());
   }
 
   // Restore the global Gmock verbosity level to its default value.
   ::testing::FLAGS_gmock_verbose = "warning";
 }