Implement --use-gl=any

Implement --use-gl=any

The behavior is this: if --use-gl=any passes in, and the default GL binding causes GPU features to be blacklisted, fallback to osmesa.  Also, in GPU process, if the default binding fails, fallback to osmesa.

This option will be used in testing to make sure accelerated path is always tested, if not on GPU, then on top of osmesa.

This CL also moves certain functions out of GpuBlacklist to GpuDataManager so we could manage the special cases when --use-gl=osmesa or --use-gl=any is passed.

BUG=97675
TEST=bots green
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102973

[Zhenyao Mo, 2011-09-22 23:57:31]

Al, could you review the ui/gfx part?

Nat, could you review the content/browser/gpu part?

[nduca, 2011-09-23 20:28:23]

LGTM

[Zhenyao Mo, 2011-09-26 20:27:35]

Al?

[alokp, 2011-09-27 15:55:48]

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.cc
File ui/gfx/gl/gl_implementation.cc (right):

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.cc#...
ui/gfx/gl/gl_implementation.cc:75: if (requested_implementation ==
kGLImplementationAny) {
I do not think "use-gl=any" means fallback to osmesa. It means keep going
through the list until you find an implementation that would work. It may be
osmesa in most cases.

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.h
File ui/gfx/gl/gl_implementation.h (right):

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.h#n...
ui/gfx/gl/gl_implementation.h:25: kGLImplementationAny
This does not seem right. "use-gl=any" is not an implementation. It is a way to
tell the browser to choose any viable implementation.

[Zhenyao Mo, 2011-09-27 17:17:31]

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.cc
File ui/gfx/gl/gl_implementation.cc (right):

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.cc#...
ui/gfx/gl/gl_implementation.cc:75: if (requested_implementation ==
kGLImplementationAny) {
On 2011/09/27 15:55:48, Alok Priyadarshi wrote:
> I do not think "use-gl=any" means fallback to osmesa. It means keep going
> through the list until you find an implementation that would work. It may be
> osmesa in most cases.

Go through the list means on Windows we will try DesktopGL next, which is bad,
because DesktopGL is not managed by Blacklist and not tested anywhere.  Falling
back to osmesa is the safe thing to do.

[alokp, 2011-09-27 17:22:24]

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.cc
File ui/gfx/gl/gl_implementation.cc (right):

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.cc#...
ui/gfx/gl/gl_implementation.cc:75: if (requested_implementation ==
kGLImplementationAny) {
On 2011/09/27 17:17:31, Zhenyao Mo wrote:
> On 2011/09/27 15:55:48, Alok Priyadarshi wrote:
> > I do not think "use-gl=any" means fallback to osmesa. It means keep going
> > through the list until you find an implementation that would work. It may be
> > osmesa in most cases.
> 
> Go through the list means on Windows we will try DesktopGL next, which is bad,
> because DesktopGL is not managed by Blacklist and not tested anywhere. 
Falling
> back to osmesa is the safe thing to do.

If DesktopGL is not supported on windows, it should not be in the list.

[Zhenyao Mo, 2011-09-27 17:36:22]

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.cc
File ui/gfx/gl/gl_implementation.cc (right):

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.cc#...
ui/gfx/gl/gl_implementation.cc:75: if (requested_implementation ==
kGLImplementationAny) {
On 2011/09/27 17:22:25, Alok Priyadarshi wrote:
> On 2011/09/27 17:17:31, Zhenyao Mo wrote:
> > On 2011/09/27 15:55:48, Alok Priyadarshi wrote:
> > > I do not think "use-gl=any" means fallback to osmesa. It means keep going
> > > through the list until you find an implementation that would work. It may
be
> > > osmesa in most cases.
> > 
> > Go through the list means on Windows we will try DesktopGL next, which is
bad,
> > because DesktopGL is not managed by Blacklist and not tested anywhere. 
> Falling
> > back to osmesa is the safe thing to do.
> 
> If DesktopGL is not supported on windows, it should not be in the list.

Currently we have only one list: allowed bindings.  We can't remove Desktop GL
from that list, because we do wanna compare DesktopGL with ANGLE for debug and
performance comparisons.

For each platform, only the default binding and osmesa are tested.  That's why I
think we should only try these two to be on the safe side.

[Zhenyao Mo, 2011-09-27 18:01:56]

revised.

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.h
File ui/gfx/gl/gl_implementation.h (right):

http://codereview.chromium.org/7967020/diff/1/ui/gfx/gl/gl_implementation.h#n...
ui/gfx/gl/gl_implementation.h:25: kGLImplementationAny
On 2011/09/27 15:55:48, Alok Priyadarshi wrote:
> This does not seem right. "use-gl=any" is not an implementation. It is a way
to
> tell the browser to choose any viable implementation.

Done.

[alokp, 2011-09-27 18:06:33]

Still looks a bit awkward but would work. LGTM.