Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: remoting/webapp/build-webapp.py

Issue 7967015: Strip debug symbols from official linux remoting builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/remoting.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/build-webapp.py
diff --git a/remoting/webapp/build-webapp.py b/remoting/webapp/build-webapp.py
index 66a28e7ad5e55854d54aa8c32939505e71f97517..c73835a73d3847e6335655967416bb623a3b64fc 100644
--- a/remoting/webapp/build-webapp.py
+++ b/remoting/webapp/build-webapp.py
@@ -47,12 +47,12 @@ def createZip(zip_path, directory):
zip.close()
-def buildWebApp(linux_strip, mimetype, destination, zip_path, plugin, files,
+def buildWebApp(buildtype, mimetype, destination, zip_path, plugin, files,
locales):
"""Does the main work of building the webapp directory and zipfile.
Args:
- linux_strip: should we strip the build on Linux (0 or !0).
+ buildtype: the type of build ("Official" or "Dev")
mimetype: A string with mimetype of plugin.
destination: A string with path to directory where the webapp will be
written.
@@ -152,7 +152,7 @@ def buildWebApp(linux_strip, mimetype, destination, zip_path, plugin, files,
shutil.copy2(plugin, newPluginPath)
# Strip the linux build.
- if ((platform.system() == 'Linux') and (linux_strip != '0')):
+ if ((platform.system() == 'Linux') and (buildtype == 'Official')):
subprocess.call(["strip", newPluginPath])
# Add unique build numbers to manifest version.
@@ -181,7 +181,7 @@ def buildWebApp(linux_strip, mimetype, destination, zip_path, plugin, files,
def main():
if len(sys.argv) < 6:
print ('Usage: build-webapp.py '
- '<linux-strip> <mime-type> <dst> <zip-path> <plugin> '
+ '<build-type> <mime-type> <dst> <zip-path> <plugin> '
'<other files...> --locales <locales...>')
sys.exit(1)
« no previous file with comments | « remoting/remoting.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698