Issue 7967015: Strip debug symbols from official linux remoting builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7967015: Strip debug symbols from official linux remoting builds. (Closed)

Created:
9 years, 3 months ago by dmac

Modified:
9 years, 3 months ago

Reviewers:
Sergey Ulanov, Lambros, dmaclach1

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Strip linux symbols from official remoting builds. BUG=87300 TEST=Build official linux build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102388

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	remoting/remoting.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	remoting/webapp/build-webapp.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lambros

LGTM Just a thought: Maybe it's easier to keep the command-line interface the same as ...

9 years, 3 months ago (2011-09-22 21:42:38 UTC) #2

dmaclach1

9 years, 3 months ago (2011-09-22 21:44:55 UTC) #3

On Thu, Sep 22, 2011 at 14:42,  <lambroslambrou@chromium.org> wrote:
> LGTM
>
> Just a thought: Maybe it's easier to keep the command-line interface the
> same as
> it was: pass the first argument as whether to strip or not.  Then put the
> "should we strip" logic in remoting.gyp.  If in future there is a reliable
> "should we strip" GYP flag, it is easier just to fix remoting.gyp, rather
> than
> mess with the command-line interface definition again.

Good thought. For right now I just wanted to go back to something I
know works. Once we have getting the crash symbols working on Linux
this stuff is going to be revamped anyways.

Expand Messages | Collapse Messages