Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: chrome/browser/ui/webui/sessions_ui.cc

Issue 7966020: [Sync] Fix Session's handling of windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits, rebase. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/foreign_session_handler.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sessions_ui.cc
diff --git a/chrome/browser/ui/webui/sessions_ui.cc b/chrome/browser/ui/webui/sessions_ui.cc
index bed4e2c0d37bfecf9cb74fbfec17aaba0e770c68..a1fb765fa89836691e9885010bc107d9a6b95ae0 100644
--- a/chrome/browser/ui/webui/sessions_ui.cc
+++ b/chrome/browser/ui/webui/sessions_ui.cc
@@ -78,8 +78,9 @@ class SessionsDOMHandler : public WebUIMessageHandler {
void GetTabList(const std::vector<SessionTab*>& tabs, ListValue* tab_list);
// Appends each entry in |windows| to |window_list| as a DictonaryValue.
- void GetWindowList(const std::vector<SessionWindow*>& windows,
- ListValue* window_list);
+ void GetWindowList(
+ const browser_sync::SyncedSession::SyncedWindowMap& windows,
+ ListValue* window_list);
// Appends each entry in |sessions| to |session_list| as a DictonaryValue.
void GetSessionList(
@@ -156,10 +157,11 @@ void SessionsDOMHandler::GetTabList(
}
void SessionsDOMHandler::GetWindowList(
- const std::vector<SessionWindow*>& windows, ListValue* window_list) {
- for (std::vector<SessionWindow*>::const_iterator it =
+ const browser_sync::SyncedSession::SyncedWindowMap& windows,
+ ListValue* window_list) {
+ for (browser_sync::SyncedSession::SyncedWindowMap::const_iterator it =
windows.begin(); it != windows.end(); ++it) {
- const SessionWindow* window = *it;
+ const SessionWindow* window = it->second;
scoped_ptr<DictionaryValue> window_data(new DictionaryValue());
window_data->SetInteger("id", window->window_id.id());
window_data->SetDouble("timestamp",
@@ -190,9 +192,12 @@ void SessionsDOMHandler::GetAllTabs(
const std::vector<const browser_sync::SyncedSession*>& sessions,
std::vector<SessionTab*>* all_tabs) {
for (size_t i = 0; i < sessions.size(); i++) {
- const std::vector<SessionWindow*>& windows = sessions[i]->windows;
- for (size_t j = 0; j < windows.size(); j++) {
- const std::vector<SessionTab*>& tabs = windows[j]->tabs;
+ const browser_sync::SyncedSession::SyncedWindowMap& windows =
+ sessions[i]->windows;
+ for (browser_sync::SyncedSession::SyncedWindowMap::const_iterator iter =
+ windows.begin();
+ iter != windows.end(); ++iter) {
+ const std::vector<SessionTab*>& tabs = iter->second->tabs;
all_tabs->insert(all_tabs->end(), tabs.begin(), tabs.end());
}
}
« no previous file with comments | « chrome/browser/ui/webui/ntp/foreign_session_handler.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698