Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: chrome/browser/ui/webui/ntp/foreign_session_handler.cc

Issue 7966020: [Sync] Fix Session's handling of windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits, rebase. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/foreign_session_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/foreign_session_handler.cc b/chrome/browser/ui/webui/ntp/foreign_session_handler.cc
index 381570c6b4968df7dff3f731a68066e253acf121..ba408531d17318d7f7409cb7e9e0320f14abf9e9 100644
--- a/chrome/browser/ui/webui/ntp/foreign_session_handler.cc
+++ b/chrome/browser/ui/webui/ntp/foreign_session_handler.cc
@@ -110,10 +110,10 @@ void ForeignSessionHandler::HandleGetForeignSessions(const ListValue* args) {
added_count < kMaxSessionsToShow; ++i) {
const SyncedSession* foreign_session = *i;
scoped_ptr<ListValue> window_list(new ListValue());
- for (std::vector<SessionWindow*>::const_iterator it =
+ for (SyncedSession::SyncedWindowMap::const_iterator it =
foreign_session->windows.begin(); it != foreign_session->windows.end();
++it) {
- SessionWindow* window = *it;
+ SessionWindow* window = it->second;
scoped_ptr<DictionaryValue> window_data(new DictionaryValue());
if (SessionWindowToValue(*window, window_data.get())) {
window_data->SetString("sessionTag", foreign_session->session_tag);
@@ -177,18 +177,18 @@ void ForeignSessionHandler::HandleOpenForeignSession(
}
SessionRestore::RestoreForeignSessionTab(profile, *tab);
} else {
- std::vector<SessionWindow*> windows;
+ std::vector<const SessionWindow*> windows;
// Note: we don't own the ForeignSessions themselves.
if (!associator->GetForeignSession(session_string_value, &windows)) {
LOG(ERROR) << "ForeignSessionHandler failed to get session data from"
"SessionModelAssociator.";
return;
}
- std::vector<SessionWindow*>::const_iterator iter_begin = windows.begin() +
- ((window_num == kInvalidId) ? 0 : window_num);
- std::vector<SessionWindow*>::const_iterator iter_end =
+ std::vector<const SessionWindow*>::const_iterator iter_begin =
+ windows.begin() + ((window_num == kInvalidId) ? 0 : window_num);
+ std::vector<const SessionWindow*>::const_iterator iter_end =
((window_num == kInvalidId) ?
- std::vector<SessionWindow*>::const_iterator(windows.end()) :
+ std::vector<const SessionWindow*>::const_iterator(windows.end()) :
iter_begin + 1);
SessionRestore::RestoreForeignSessionWindows(profile, iter_begin, iter_end);
}
« no previous file with comments | « chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc ('k') | chrome/browser/ui/webui/sessions_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698