[Sync] Fix Session's handling of windows.

chrome/browser/sync/glue/session_model_associator.cc

Index: chrome/browser/sync/glue/session_model_associator.cc
diff --git a/chrome/browser/sync/glue/session_model_associator.cc b/chrome/browser/sync/glue/session_model_associator.cc
index 6b2ca7d99511da53f61a6cebbfa115fa8172a203..628e6ba6258241833269ed33c0c25819b62396fa 100644
--- a/chrome/browser/sync/glue/session_model_associator.cc
+++ b/chrome/browser/sync/glue/session_model_associator.cc
@@ -13,6 +13,7 @@
 #include "base/sys_info.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/sessions/session_id.h"
 #include "chrome/browser/sessions/session_service_factory.h"
 #include "chrome/browser/sync/api/sync_error.h"
 #include "chrome/browser/sync/glue/synced_session.h"
@@ -144,10 +145,9 @@ void SessionModelAssociator::ReassociateWindows(bool reload_tabs) {
   header_s->set_device_type(sync_pb::SessionHeader_DeviceType_TYPE_OTHER);
 #endif
 
-  size_t window_num = 0;
+  synced_session_tracker_.ResetSessionTracking(local_tag);
   std::set<SyncedWindowDelegate*> windows =
       SyncedWindowDelegate::GetSyncedWindowDelegates();
-  current_session->windows.reserve(windows.size());
   for (std::set<SyncedWindowDelegate*>::const_iterator i =
        windows.begin(); i != windows.end(); ++i) {
     // Make sure the window has tabs and a viewable window. The viewable window
@@ -156,8 +156,7 @@ void SessionModelAssociator::ReassociateWindows(bool reload_tabs) {
     // for us to get a handle to a browser that is about to be removed. If
     // the tab count is 0 or the window is NULL, the browser is about to be
     // deleted, so we ignore it.
-    if (ShouldSyncWindow(*i) && (*i)->GetTabCount() &&
-        (*i)->HasWindow()) {
+    if (ShouldSyncWindow(*i) && (*i)->GetTabCount() && (*i)->HasWindow()) {
       sync_pb::SessionWindow window_s;
       SessionID::id_type window_id = (*i)->GetSessionId();
       VLOG(1) << "Reassociating window " << window_id << " with " <<
@@ -191,19 +190,18 @@ void SessionModelAssociator::ReassociateWindows(bool reload_tabs) {
         *header_window = window_s;
 
         // Update this window's representation in the synced session tracker.
-        if (window_num >= current_session->windows.size()) {
-          // This a new window, create it.
-          current_session->windows.push_back(new SessionWindow());
-        }
+        synced_session_tracker_.PutWindowInSession(local_tag, window_id);

[akalin, 2011/10/01 01:54:14]

see comment below about making PutWindowInSession also fill in info from
specifics

         PopulateSessionWindowFromSpecifics(
             local_tag,
             window_s,
             base::Time::Now(),
-            current_session->windows[window_num++],
+            current_session->windows[window_id],
             &synced_session_tracker_);
       }
     }
   }
+  // Free memory for closed windows and tabs.
+  synced_session_tracker_.CleanupSession(local_tag);
 
   sync_api::WriteTransaction trans(FROM_HERE, sync_service_->GetUserShare());
   sync_api::WriteNode header_node(&trans);
@@ -334,9 +332,8 @@ bool SessionModelAssociator::WriteTabContentsToSyncModel(
 
   // Convert to a local representation and store in synced session tracker.
   SessionTab* session_tab =
-      synced_session_tracker_.GetSessionTab(GetCurrentMachineTag(),
-                                            tab_s->tab_id(),
-                                            false);
+      synced_session_tracker_.GetTab(GetCurrentMachineTag(),
+                                     tab_s->tab_id());
   PopulateSessionTabFromSpecifics(*tab_s,
                                   base::Time::Now(),
                                   session_tab);
@@ -430,7 +427,7 @@ bool SessionModelAssociator::AssociateModels(SyncError* error) {
   DCHECK(CalledOnValidThread());
 
   // Ensure that we disassociated properly, otherwise memory might leak.
-  DCHECK(synced_session_tracker_.empty());
+  DCHECK(synced_session_tracker_.Empty());
   DCHECK_EQ(0U, tab_pool_.capacity());
 
   local_session_syncid_ = sync_api::kInvalidId;
@@ -487,7 +484,7 @@ bool SessionModelAssociator::AssociateModels(SyncError* error) {
 
 bool SessionModelAssociator::DisassociateModels(SyncError* error) {
   DCHECK(CalledOnValidThread());
-  synced_session_tracker_.clear();
+  synced_session_tracker_.Clear();
   tab_map_.clear();
   tab_pool_.clear();
   local_session_syncid_ = sync_api::kInvalidId;
@@ -634,37 +631,37 @@ bool SessionModelAssociator::AssociateForeignSpecifics(
     // Load (or create) the SyncedSession object for this client.
     SyncedSession* foreign_session =
         synced_session_tracker_.GetSession(foreign_session_tag);
-
     const sync_pb::SessionHeader& header = specifics.header();
     PopulateSessionHeaderFromSpecifics(header, foreign_session);
-    foreign_session->windows.reserve(header.window_size());
-    VLOG(1) << "Associating " << foreign_session_tag << " with " <<
-        header.window_size() << " windows.";
-    size_t i;
-    for (i = 0; i < static_cast<size_t>(header.window_size()); ++i) {
-      if (i >= foreign_session->windows.size()) {
-        // This a new window, create it.
-        foreign_session->windows.push_back(new SessionWindow());
-      }
+
+    // Reset the tab/window tracking for this session (must do this before
+    // we start calling PutWindowInSessino and PutTabInWindow so that all

[akalin, 2011/10/01 01:54:14]

Sessino -> Session

[Nicolas Zea, 2011/10/03 18:36:50]

Done.

+    // unused tabs/windows get cleared by the CleanupSession(...) call).
+    synced_session_tracker_.ResetSessionTracking(foreign_session_tag);
+
+    // Process all the windows and their tab information.
+    int num_windows = header.window_size();
+    VLOG(1) << "Associating " << foreign_session_tag << " with "
+            << num_windows << " windows.";
+    for (int i = 0; i < num_windows; ++i) {
       const sync_pb::SessionWindow& window_s = header.window(i);
+      SessionID::id_type window_id = window_s.window_id();
+      synced_session_tracker_.PutWindowInSession(foreign_session_tag,
+                                                 window_id);
       PopulateSessionWindowFromSpecifics(foreign_session_tag,

[akalin, 2011/10/01 01:54:14]

I think the PopulateSessionWindowFromSpecifics logic more properly belongs in
the SyncedSessionTracker, merged with PutWindowInSession.  So it'd look like:

synced_session_tracker_.PutWindowInSession(foreign_session_tag, window_id,
window_s, modification_time);

                                          window_s,
                                          modification_time,
-                                         foreign_session->windows[i],
+                                         foreign_session->windows[window_id],
                                          &synced_session_tracker_);
     }
-    // Remove any remaining windows (in case windows were closed)
-    for (; i < foreign_session->windows.size(); ++i) {
-      delete foreign_session->windows[i];
-    }
-    foreign_session->windows.resize(header.window_size());
+
+    // Delete any closed windows and unused tabs as necessary.
+    synced_session_tracker_.CleanupSession(foreign_session_tag);
   } else if (specifics.has_tab()) {
     const sync_pb::SessionTab& tab_s = specifics.tab();
     SessionID::id_type tab_id = tab_s.tab_id();
     SessionTab* tab =

[akalin, 2011/10/01 01:54:14]

I think there's a similar need to rename GetTab to, say, PutWindowslessTab() and
have it take the tab specifics

[Nicolas Zea, 2011/10/03 18:36:50]

But it's not necessarily windowless. It's possible the meta node already
processed it before the tab node arrived, in which case this will get and fill
the previously created SessionTab. 

-        synced_session_tracker_.GetSessionTab(foreign_session_tag,
-                                              tab_id,
-                                              false);
+        synced_session_tracker_.GetTab(foreign_session_tag, tab_id);
     PopulateSessionTabFromSpecifics(tab_s, modification_time, tab);
   } else {
     NOTREACHED();
@@ -730,11 +727,13 @@ void SessionModelAssociator::PopulateSessionWindowFromSpecifics(
     }
   }
   session_window->timestamp = mtime;
-  session_window->tabs.resize(specifics.tab_size());
+  session_window->tabs.resize(specifics.tab_size(), NULL);
   for (int i = 0; i < specifics.tab_size(); i++) {
     SessionID::id_type tab_id = specifics.tab(i);
-    session_window->tabs[i] =
-        tracker->GetSessionTab(session_tag, tab_id, true);
+    tracker->PutTabInWindow(session_tag,
+                            session_window->window_id.id(),
+                            tab_id,
+                            i);
   }
 }
 
@@ -743,6 +742,7 @@ void SessionModelAssociator::PopulateSessionTabFromSpecifics(
     const sync_pb::SessionTab& specifics,
     const base::Time& mtime,
     SessionTab* tab) {
+  DCHECK_EQ(tab->tab_id.id(), specifics.tab_id());
   if (specifics.has_tab_id())
     tab->tab_id.set_id(specifics.tab_id());
   if (specifics.has_window_id())
@@ -918,8 +918,7 @@ bool SessionModelAssociator::GetLocalSession(
   DCHECK(CalledOnValidThread());
   if (current_machine_tag_.empty())
     return false;
-  *local_session =
-      synced_session_tracker_.GetSession(GetCurrentMachineTag());
+  *local_session = synced_session_tracker_.GetSession(GetCurrentMachineTag());
   return true;
 }
 
@@ -931,7 +930,7 @@ bool SessionModelAssociator::GetAllForeignSessions(
 
 bool SessionModelAssociator::GetForeignSession(

[akalin, 2011/10/01 01:54:14]

append ForTest, return vector directly

     const std::string& tag,
-    std::vector<SessionWindow*>* windows) {
+    std::vector<const SessionWindow*>* windows) {
   DCHECK(CalledOnValidThread());
   return synced_session_tracker_.LookupSessionWindows(tag, windows);
 }
@@ -944,23 +943,8 @@ bool SessionModelAssociator::GetForeignTab(
   return synced_session_tracker_.LookupSessionTab(tag, tab_id, tab);
 }
 
-// Static
-bool SessionModelAssociator::SessionWindowHasNoTabsToSync(
-    const SessionWindow& window) {
-  int num_populated = 0;
-  for (std::vector<SessionTab*>::const_iterator i = window.tabs.begin();
-      i != window.tabs.end(); ++i) {
-    const SessionTab* tab = *i;
-    if (IsValidSessionTab(*tab))
-      num_populated++;
-  }
-  if (num_populated == 0)
-    return true;
-  return false;
-}
-
 // Valid local tab?
-bool SessionModelAssociator::IsValidTab(const SyncedTabDelegate& tab) {
+bool SessionModelAssociator::IsValidTab(const SyncedTabDelegate& tab) const {
   DCHECK(CalledOnValidThread());
   if ((tab.profile() == sync_service_->profile() ||
        sync_service_->profile() == NULL)) {          // For tests.
@@ -981,26 +965,6 @@ bool SessionModelAssociator::IsValidTab(const SyncedTabDelegate& tab) {
   return false;
 }
 
-// Static.
-bool SessionModelAssociator::IsValidSessionTab(const SessionTab& tab) {
-  if (tab.navigations.empty())
-    return false;
-  int selected_index = tab.current_navigation_index;
-  selected_index = std::max(
-      0,
-      std::min(selected_index,
-          static_cast<int>(tab.navigations.size() - 1)));
-  if (selected_index == 0 &&
-      tab.navigations.size() == 1 &&
-      tab.navigations.at(selected_index).virtual_url().GetOrigin() ==
-          GURL(chrome::kChromeUINewTabURL)) {
-    // This is a new tab with no further history, skip.
-    return false;
-  }
-  return true;
-}
-
-
 void SessionModelAssociator::QuitLoopForSubtleTesting() {
   if (waiting_for_change_) {
     VLOG(1) << "Quitting MessageLoop for test.";