[Sync] Fix Session's handling of windows.

chrome/browser/sync/glue/synced_session.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_SYNCED_SESSION_H_
 #define CHROME_BROWSER_SYNC_GLUE_SYNCED_SESSION_H_
 #pragma once
 
+#include <map>
 #include <string>
-#include <vector>
+
+#include "chrome/browser/sessions/session_id.h"
 
 struct SessionWindow;
 
 namespace browser_sync {
 
 // Defines a synced session for use by session sync. A synced session is a
 // list of windows along with a unique session identifer (tag) and meta-data
 // about the device being synced.
 struct SyncedSession {
+  typedef std::map<SessionID::id_type, SessionWindow*> SyncedWindowMap;
+
   // The type of device.
   enum DeviceType {
     TYPE_UNSET = 0,
     TYPE_WIN = 1,
     TYPE_MACOSX = 2,
     TYPE_LINUX = 3,
     TYPE_CHROMEOS = 4,
     TYPE_OTHER = 5
   };
 
   SyncedSession();
   ~SyncedSession();
 
   // Unique tag for each session.
   std::string session_tag;
   // User-visible name
   std::string session_name;
   DeviceType device_type;
-  std::vector<SessionWindow*> windows;
+  SyncedWindowMap windows;

[akalin, 2011/09/26 18:34:44]

Add a comment saying that the SessionWindow*s are owned

[Nicolas Zea, 2011/09/26 19:47:36]

Done.

 };

[akalin, 2011/09/26 18:34:44]

DISALLOW_COPY_AND_ASSIGN()?  Seems like things will break if you allow this to
be copied (double-frees of SessionWindow*, etc)

Alternatively, make SyncedWindowMap have linked_ptr<SessionWindow>

[Nicolas Zea, 2011/09/26 19:47:36]

Done.

 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_SYNCED_SESSION_H_