Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 7966016: Fix lack of initialization for delegate delayed complete flag. (Closed)

Created:
9 years, 3 months ago by Randy Smith (Not in Mondays)
Modified:
9 years, 3 months ago
CC:
chromium-reviews, dpranke+watch-content_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix lack of initialization for delegate delayed complete flag. BUG=94468 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102535

Patch Set 1 #

Patch Set 2 : Fix suppressions that should be fixed by this test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/download/download_item.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Randy Smith (Not in Mondays)
Andy: PTAL. John: I think this was just a typo, but I'm including you in ...
9 years, 3 months ago (2011-09-22 20:57:24 UTC) #1
Randy Smith (Not in Mondays)
Let's try this again, only with reviewers this time. Andy: PTAL. John: I think this ...
9 years, 3 months ago (2011-09-22 20:57:54 UTC) #2
Nirnimesh
PYAUTO_TESTS LGTM
9 years, 3 months ago (2011-09-22 21:13:44 UTC) #3
ahendrickson
Downloads LGTM. On 2011/09/22 21:13:44, Nirnimesh wrote: > PYAUTO_TESTS LGTM
9 years, 3 months ago (2011-09-22 21:27:44 UTC) #4
jam
lgtm, sorry I forgot about the other constructors
9 years, 3 months ago (2011-09-23 01:15:10 UTC) #5
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/7966016/3001
9 years, 3 months ago (2011-09-23 14:57:58 UTC) #6
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 3 months ago (2011-09-23 16:58:46 UTC) #7
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/7966016/3001
9 years, 3 months ago (2011-09-23 17:12:31 UTC) #8
commit-bot: I haz the power
9 years, 3 months ago (2011-09-23 18:27:12 UTC) #9
Change committed as 102535

Powered by Google App Engine
This is Rietveld 408576698