Issue 7963001: aura: Make 'skia' target build and link without gtk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7963001: aura: Make 'skia' target build and link without gtk. (Closed)

Created:
9 years, 3 months ago by sadrul

Modified:
9 years, 3 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

aura: Make 'skia' target build and link without gtk. Depends on http://codereview.chromium.org/7904034/ BUG=97131 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102082

Patch Set 1 #

Total comments: 2

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -12 lines)			Patch
	M	skia/skia.gyp	View		3 chunks	+17 lines, -12 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

Looks ok, but one question below: http://codereview.chromium.org/7963001/diff/1/skia/skia.gyp File skia/skia.gyp (right): http://codereview.chromium.org/7963001/diff/1/skia/skia.gyp#newcode772 skia/skia.gyp:772: [ 'use_glib == ...

9 years, 3 months ago (2011-09-19 21:58:09 UTC) #2

sadrul

http://codereview.chromium.org/7963001/diff/1/skia/skia.gyp File skia/skia.gyp (right): http://codereview.chromium.org/7963001/diff/1/skia/skia.gyp#newcode772 skia/skia.gyp:772: [ 'use_glib == 1', { On 2011/09/19 21:58:09, Nico ...

9 years, 3 months ago (2011-09-19 22:00:10 UTC) #3

Nico

LGTM Please add "Depends on http://codereview.chromium.org/7904034/" to the CL description (and don't land before that's ...

9 years, 3 months ago (2011-09-19 22:08:06 UTC) #4

Good point! Done. Thanks :)

Expand Messages | Collapse Messages