Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chrome/test/base/in_process_browser_test.cc

Issue 7960001: Fix activation problem when showing bubble view (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix OmniboxApiTest.PopupStaysClosed failure Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/in_process_browser_test.cc
diff --git a/chrome/test/base/in_process_browser_test.cc b/chrome/test/base/in_process_browser_test.cc
index 7986608b1224b1f2f8b67e485d17db3933dea469..178c6f0096bc329c8f08c76298d0e7eb93a08ba0 100644
--- a/chrome/test/base/in_process_browser_test.cc
+++ b/chrome/test/base/in_process_browser_test.cc
@@ -274,6 +274,8 @@ Browser* InProcessBrowserTest::CreateBrowserForPopup(Profile* profile) {
}
void InProcessBrowserTest::AddBlankTabAndShow(Browser* browser) {
+ browser->window()->Show();
+
ui_test_utils::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
NotificationService::AllSources());
@@ -281,7 +283,7 @@ void InProcessBrowserTest::AddBlankTabAndShow(Browser* browser) {
GURL(chrome::kAboutBlankURL), PageTransition::START_PAGE);
observer.Wait();
- browser->window()->Show();
+ browser->window()->Activate();
}
#if defined(OS_POSIX)
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698