Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7957001: Revert 101785 - Add --use-more-webui runtime flag to toggle WebUI replacements for native dialogs. (Closed)

Created:
9 years, 3 months ago by scherkus (not reviewing)
Modified:
9 years, 3 months ago
Reviewers:
flackr
CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana
Visibility:
Public.

Description

Revert 101785 - Add --use-more-webui runtime flag to toggle WebUI replacements for native dialogs. This adds the flag --use-more-webui to allow turning on WebUI replacements for native dialogs. This flag is automatically set when --use-pure-views is specified. Modifies replaced native dialogs to be toggled based on flag value. BookmarkEditor has also been refactored to use static constructors to EditDetails to describe what is being edited to make the code more readable. BUG=96935 TEST=Tested that webui dialogs can be turned on or left off with --use-more-webui. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101581 Review URL: http://codereview.chromium.org/7670041 TBR=flackr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -294 lines) Patch
M build/common.gypi View 6 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller.cc View 2 chunks +17 lines, -6 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_editor.h View 2 chunks +8 lines, -36 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_editor.cc View 1 chunk +8 lines, -40 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/certificate_viewer.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 2 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/ui/gtk/certificate_viewer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/gtk/certificate_viewer.cc View 4 chunks +7 lines, -7 lines 0 comments Download
MM chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 3 chunks +10 lines, -6 lines 0 comments Download
MM chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc View 2 chunks +15 lines, -4 lines 0 comments Download
MM chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 chunk +5 lines, -5 lines 0 comments Download
MM chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc View 11 chunks +13 lines, -22 lines 0 comments Download
MM chrome/browser/ui/views/hung_renderer_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/webui/bookmarks_ui.cc View 3 chunks +0 lines, -38 lines 0 comments Download
MM chrome/browser/ui/webui/certificate_viewer.h View 1 chunk +1 line, -2 lines 0 comments Download
MM chrome/browser/ui/webui/certificate_viewer.cc View 2 chunks +5 lines, -11 lines 0 comments Download
MM chrome/browser/ui/webui/chrome_web_ui.h View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/browser/ui/webui/chrome_web_ui.cc View 2 chunks +0 lines, -16 lines 0 comments Download
MM chrome/browser/ui/webui/chrome_web_ui_factory.cc View 3 chunks +8 lines, -3 lines 0 comments Download
MM chrome/browser/ui/webui/html_dialog_ui.h View 1 chunk +0 lines, -3 lines 0 comments Download
MM chrome/browser/ui/webui/html_dialog_ui.cc View 2 chunks +2 lines, -6 lines 0 comments Download
MM chrome/browser/ui/webui/hung_renderer_dialog.h View 3 chunks +0 lines, -6 lines 0 comments Download
MM chrome/browser/ui/webui/hung_renderer_dialog.cc View 8 chunks +7 lines, -25 lines 0 comments Download
MM chrome/chrome_browser.gypi View 5 chunks +36 lines, -3 lines 0 comments Download
MM chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
9 years, 3 months ago (2011-09-19 18:49:41 UTC) #1
flackr
9 years, 3 months ago (2011-09-19 18:51:35 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698