Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2517)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 7955001: Update Chrome to use new context notification APIs from WebKit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | content/renderer/content_renderer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index d2b21683c4f74e9a3dae5039fd1b3fd8a6aaf530..8ce0ae58bb188ae3d1453a2a35bd6268df4ef9d5 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -638,30 +638,19 @@ bool ChromeContentRendererClient::ShouldPumpEventsDuringCookieMessage() {
return CommandLine::ForCurrentProcess()->HasSwitch(switches::kChromeFrame);
}
-void ChromeContentRendererClient::DidCreateScriptContext(WebFrame* frame) {
- // This can happen if the frame has JavaScript disabled. The context was
- // created but we can't access it through mainWorldScriptContext().
- if (frame->mainWorldScriptContext().IsEmpty())
- return;
-
+void ChromeContentRendererClient::DidCreateScriptContext(
+ WebFrame* frame, v8::Handle<v8::Context> context, int world_id) {
EventBindings::HandleContextCreated(frame,
- frame->mainWorldScriptContext(),
+ context,
extension_dispatcher_.get(),
- 0); // isolated world ID
+ world_id);
}
-void ChromeContentRendererClient::DidDestroyScriptContext(WebFrame* frame) {
+void ChromeContentRendererClient::WillReleaseScriptContext(
+ WebFrame* frame, v8::Handle<v8::Context> context, int world_id) {
EventBindings::HandleContextDestroyed(frame);
}
-void ChromeContentRendererClient::DidCreateIsolatedScriptContext(
- WebFrame* frame, int world_id, v8::Handle<v8::Context> context) {
- EventBindings::HandleContextCreated(frame,
- context,
- extension_dispatcher_.get(),
- world_id);
-}
-
unsigned long long ChromeContentRendererClient::VisitedLinkHash(
const char* canonical_url, size_t length) {
return visited_link_slave_->ComputeURLFingerprint(canonical_url, length);
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | content/renderer/content_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698