Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 7955001: Update Chrome to use new context notification APIs from WebKit. (Closed)

Created:
9 years, 3 months ago by Aaron Boodman
Modified:
9 years, 3 months ago
Reviewers:
jamesr, brettw, jam, Matt Perry
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, dpranke+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Update Chrome to use new context notification APIs from WebKit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102166

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -57 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +6 lines, -17 lines 0 comments Download
M content/renderer/content_renderer_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/renderer/mock_content_renderer_client.h View 1 chunk +6 lines, -5 lines 0 comments Download
M content/renderer/mock_content_renderer_client.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M content/renderer/render_view.h View 1 chunk +6 lines, -5 lines 0 comments Download
M content/renderer/render_view.cc View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Aaron Boodman
9 years, 3 months ago (2011-09-19 18:27:26 UTC) #1
Matt Perry
Nice. LGTM
9 years, 3 months ago (2011-09-19 19:12:00 UTC) #2
Aaron Boodman
Can I get an LG from a content/renderer owner?
9 years, 3 months ago (2011-09-21 20:56:54 UTC) #3
jamesr
lgtm
9 years, 3 months ago (2011-09-21 20:59:53 UTC) #4
jam
9 years, 3 months ago (2011-09-21 21:01:56 UTC) #5
lgtm

you'll want to update src/content/shell/shell_content_renderer_client.h as well

Powered by Google App Engine
This is Rietveld 408576698