chrome/browser/resources/ntp4/trash.js - Issue 7951011: Moving where I'm doing dropEffect normalization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/trash.js

Issue 7951011: Moving where I'm doing dropEffect normalization. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: code review changes from conversation with estade over chat Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/ntp4/trash.js

diff --git a/chrome/browser/resources/ntp4/trash.js b/chrome/browser/resources/ntp4/trash.js

index 3fad9df468a78512a472f09ca0fd0f9c31ea7735..cd36f225d13771e1203cd16da2e67aeba150f0e9 100644

--- a/chrome/browser/resources/ntp4/trash.js

+++ b/chrome/browser/resources/ntp4/trash.js

@@ -43,8 +43,8 @@ cr.define('ntp4', function() {

doDragOver: function(e) {

ntp4.getCurrentlyDraggingTile().dragClone.classList.add(

'hovering-on-trash');

+ ntp4.setCurrentDropEffect(e.dataTransfer, 'move');

e.preventDefault();

- e.dataTransfer.dropEffect = 'move';

/**