Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 7948008: Using config/k8 as default config path in the taget_arch other than ia32. (Closed)

Created:
9 years, 3 months ago by michaelbai
Modified:
9 years, 3 months ago
Reviewers:
agl
CC:
chromium-reviews
Visibility:
Public.

Description

It seemed that linux_chromeos_arm bot still use openssl, Changed the linux logic to be same as one before issue 7920010. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101988

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M openssl.gyp View 1 chunk +18 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
michaelbai
The previous cl failed on linux_chromeos_arm bot which seems still use openssl.
9 years, 3 months ago (2011-09-19 23:20:49 UTC) #1
michaelbai
On 2011/09/19 23:20:49, michaelbai wrote: > The previous cl failed on linux_chromeos_arm bot which seems ...
9 years, 3 months ago (2011-09-19 23:21:25 UTC) #2
agl
NACK. We need to find out why ChromeOS is using OpenSSL first. The ARM clobber ...
9 years, 3 months ago (2011-09-20 17:33:08 UTC) #3
michaelbai
Here it is http://build.chromium.org/p/chromium/builders/Arm/builds/17555/steps/update/logs/stdio On 2011/09/20 17:33:08, agl wrote: > NACK. > > We need ...
9 years, 3 months ago (2011-09-20 18:25:53 UTC) #4
agl
9 years, 3 months ago (2011-09-20 18:33:35 UTC) #5
On Tue, Sep 20, 2011 at 2:25 PM,  <michaelbai@chromium.org> wrote:
> Here it is
>
>
http://build.chromium.org/p/chromium/builders/Arm/builds/17555/steps/update/l...

Ah, ok, it's just a GYP error. It's probably pulling in openssl due to
flip_in_mem_edsm_server.

Change LGTM then, although I'm not sure why k8 was made the default.
As a 64-bit platform, it would seem that piii would make a better
default, no?


Cheers

AGL

Powered by Google App Engine
This is Rietveld 408576698