Get rid of content::DidEndMainMessageLoop since it was declared in content but defined in chrome,...

content/browser/browser_main.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_main.h"
 
 #include "base/allocator/allocator_shim.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
@@ skipping 149 matching lines @@
 
 namespace content {
 
 BrowserMainParts::BrowserMainParts(const MainFunctionParams& parameters)
     : parameters_(parameters),
       parsed_command_line_(parameters.command_line_),
       result_code_(content::RESULT_CODE_NORMAL_EXIT) {
 }
 
 BrowserMainParts::~BrowserMainParts() {
+#if defined(OS_WIN)

[willchan no longer on Chromium, 2011/09/19 21:52:49]

Looks to me like this should be in BrowserMainPartsWin. Same with the
OleInitialize() call below.

[jam, 2011/09/19 22:13:31]

BrowserMainPartsWin is in chrome, but we want this function for all embedders of
content, hence why it's here

[willchan no longer on Chromium, 2011/09/19 22:25:43]

Make sense. I suspect we should probably be created the content equivalents of
BrowserMainParts{Win|Mac|etc} eventually.

[jam, 2011/09/19 22:40:48]

I avoided that because Chrome also has its own platform versions, which derive
from a common chrome class. so if content also had 3 versions, we'd have to make
the base chrome one derive from three different classes depending on the
platform, which seemed a little hard on the eyes

+  OleUninitialize();
+#endif
 }
 
 void BrowserMainParts::EarlyInitialization() {
   PreEarlyInitialization();
 
 #if defined(OS_WIN)
   net::EnsureWinsockInit();
 #endif
 
   // Use NSS for SSL by default.
@@ skipping 229 matching lines @@
   base::win::ScopedCOMInitializer com_initializer;
 #endif  // OS_WIN
 
   base::StatisticsRecorder statistics;
 
   parts->RunMainMessageLoopParts();
 
   TRACE_EVENT_END_ETW("BrowserMain", 0, 0);
   return parts->result_code();
 }