Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 7948004: Removing singelton property of MediaStreamManager. (Closed)

Created:
9 years, 3 months ago by mflodman_chromium_OOO
Modified:
9 years, 3 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, dpranke+watch-content_chromium.org, annacc+watch_chromium.org, joi+watch-content_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

Removing singelton property of MediaStreamManager. This is almost the same patch [1] as was reverted last week due to flakiness in one of the Win tests, but for one change: MediaStreamManager is not called from MediaStreamDispatcherHost::OnChannelClosing, to avoid shut-down crash. This will be changed as soon as the shut-down issue is solved. [1] http://codereview.chromium.org/7649016/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -99 lines) Patch
M chrome/browser/profiles/profile_io_data.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/browser_render_process_host.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 3 chunks +8 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 2 chunks +15 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 6 chunks +58 lines, -16 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 4 chunks +7 lines, -12 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 8 chunks +18 lines, -26 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 2 chunks +11 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 3 chunks +11 lines, -13 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.h View 2 chunks +8 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 7 chunks +33 lines, -11 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 1 chunk +11 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 2 chunks +29 lines, -2 lines 0 comments Download
M content/browser/resource_context.h View 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/resource_context.cc View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
willchan no longer on Chromium
chrome/browser/profiles: LGTM
9 years, 3 months ago (2011-09-19 23:24:37 UTC) #1
wjia(left Chromium)
lgtm.
9 years, 3 months ago (2011-09-19 23:27:40 UTC) #2
jam
lgtm in the future, when relanding a reverted change, it's very helpful to first upload ...
9 years, 3 months ago (2011-09-20 16:11:37 UTC) #3
mflodman_chromium_OOO
> in the future, when relanding a reverted change, it's very helpful to first > ...
9 years, 3 months ago (2011-09-20 18:20:32 UTC) #4
mflodman_chromium_OOO
9 years, 3 months ago (2011-09-20 18:20:35 UTC) #5
> in the future, when relanding a reverted change, it's very helpful to first
> upload the original change, then upload again with the fixes. that way
previous
> reviewers can see what changed.
Good point, will do.

Thanks for the quick replies!

Powered by Google App Engine
This is Rietveld 408576698