Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6324)

Unified Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 7948003: Update error badge on wrench menu button (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar_view.cc
diff --git a/chrome/browser/ui/views/toolbar_view.cc b/chrome/browser/ui/views/toolbar_view.cc
index 2d627500a1e6102155e72255ba58b2d3aa174f43..7e6b5dde9420c66e62bc7531ed558b691d441cab 100644
--- a/chrome/browser/ui/views/toolbar_view.cc
+++ b/chrome/browser/ui/views/toolbar_view.cc
@@ -112,6 +112,8 @@ ToolbarView::ToolbarView(Browser* browser)
registrar_.Add(this,
chrome::NOTIFICATION_MODULE_INCOMPATIBILITY_BADGE_CHANGE,
NotificationService::AllSources());
+ registrar_.Add(this, chrome::NOTIFICATION_GLOBAL_ERRORS_CHANGED,
+ Source<Profile>(browser_->profile()));
}
ToolbarView::~ToolbarView() {
@@ -410,16 +412,20 @@ void ToolbarView::ButtonPressed(views::Button* sender,
void ToolbarView::Observe(int type,
const NotificationSource& source,
const NotificationDetails& details) {
- if (type == chrome::NOTIFICATION_PREF_CHANGED) {
- std::string* pref_name = Details<std::string>(details).ptr();
- if (*pref_name == prefs::kShowHomeButton) {
- Layout();
- SchedulePaint();
+ switch (type) {
+ case chrome::NOTIFICATION_PREF_CHANGED: {
+ std::string* pref_name = Details<std::string>(details).ptr();
+ if (*pref_name == prefs::kShowHomeButton) {
+ Layout();
+ SchedulePaint();
+ }
+ break;
}
- } else if (
- type == chrome::NOTIFICATION_UPGRADE_RECOMMENDED ||
- type == chrome::NOTIFICATION_MODULE_INCOMPATIBILITY_BADGE_CHANGE) {
- UpdateAppMenuBadge();
+ case chrome::NOTIFICATION_UPGRADE_RECOMMENDED:
+ case chrome::NOTIFICATION_MODULE_INCOMPATIBILITY_BADGE_CHANGE:
+ case chrome::NOTIFICATION_GLOBAL_ERRORS_CHANGED:
+ UpdateAppMenuBadge();
+ break;
sky 2011/09/19 23:53:01 add default: NOTREACHED
sail 2011/09/20 00:09:07 Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698