Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6688)

Unified Diff: chrome/browser/ui/global_error_service_unittest.cc

Issue 7948003: Update error badge on wrench menu button (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/global_error_service_factory.cc ('k') | chrome/browser/ui/gtk/browser_toolbar_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/global_error_service_unittest.cc
diff --git a/chrome/browser/ui/global_error_service_unittest.cc b/chrome/browser/ui/global_error_service_unittest.cc
index 0135a9f9d49e793386fe79c1aee2ac512c00cefb..2c16bc2a9e7f0ee31d83e5047e16284cc0566316 100644
--- a/chrome/browser/ui/global_error_service_unittest.cc
+++ b/chrome/browser/ui/global_error_service_unittest.cc
@@ -108,7 +108,7 @@ class MenuError : public BaseError {
// Test adding errors to the global error service.
TEST(GlobalErrorServiceTest, AddError) {
- scoped_ptr<GlobalErrorService> service(new GlobalErrorService);
+ scoped_ptr<GlobalErrorService> service(new GlobalErrorService(NULL));
EXPECT_EQ(0u, service->errors().size());
BaseError* error1 = new BaseError;
@@ -130,7 +130,7 @@ TEST(GlobalErrorServiceTest, AddError) {
// Test removing errors from the global error service.
TEST(GlobalErrorServiceTest, RemoveError) {
- scoped_ptr<GlobalErrorService> service(new GlobalErrorService);
+ scoped_ptr<GlobalErrorService> service(new GlobalErrorService(NULL));
BaseError error1;
service->AddGlobalError(&error1);
BaseError error2;
@@ -155,7 +155,7 @@ TEST(GlobalErrorServiceTest, GetMenuItem) {
MenuError* error2 = new MenuError(2);
MenuError* error3 = new MenuError(3);
- GlobalErrorService service;
+ GlobalErrorService service(NULL);
service.AddGlobalError(error1);
service.AddGlobalError(error2);
service.AddGlobalError(error3);
@@ -171,7 +171,7 @@ TEST(GlobalErrorServiceTest, GetBadgeID) {
BadgeError error2(2);
BadgeError* error3 = new BadgeError(3);
- GlobalErrorService service;
+ GlobalErrorService service(NULL);
EXPECT_EQ(0, service.GetFirstBadgeResourceID());
service.AddGlobalError(error1);
« no previous file with comments | « chrome/browser/ui/global_error_service_factory.cc ('k') | chrome/browser/ui/gtk/browser_toolbar_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698