Issue 7948003: Update error badge on wrench menu button

Issue 7948003: Update error badge on wrench menu button (Closed)

Created:
9 years, 3 months ago by sail

Modified:
9 years, 3 months ago

Reviewers:
Robert Sesek, commit-bot: I haz the power, Elliot Glaysher, sky

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update error badge on wrench menu button With this change we now update the error badge on the wrench menu button if a global error is updated, added or removed. BUG=95146 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101904

Patch Set 1 #

Patch Set 2 : gkt and views #

Total comments: 4

Patch Set 3 : address review comments #

Total comments: 6

Patch Set 4 : address review comments #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -18 lines)			Patch
M	chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm	View	1 2	4 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/ui/global_error_service.h	View	1 2 3	3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/ui/global_error_service.cc	View		3 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/browser/ui/global_error_service_factory.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/global_error_service_unittest.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_toolbar_gtk.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.cc	View	1 2 3	2 chunks	+17 lines, -9 lines	0 comments	Download
M	chrome/common/chrome_notification_types.h	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

http://codereview.chromium.org/7948003/diff/2001/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right): http://codereview.chromium.org/7948003/diff/2001/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm#newcode99 chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:99: @property(assign, nonatomic) Browser* browser; @property goes above method declarations

9 years, 3 months ago (2011-09-19 18:57:36 UTC) #2

Elliot Glaysher

the gtk code lgtm but... http://codereview.chromium.org/7948003/diff/2001/chrome/browser/ui/global_error_service.h File chrome/browser/ui/global_error_service.h (right): http://codereview.chromium.org/7948003/diff/2001/chrome/browser/ui/global_error_service.h#newcode22 chrome/browser/ui/global_error_service.h:22: class GlobalErrorService : public ...

9 years, 3 months ago (2011-09-19 19:16:06 UTC) #3

sail

9 years, 3 months ago (2011-09-19 19:19:58 UTC) #4

sky

LGTM with the following changes. http://codereview.chromium.org/7948003/diff/6001/chrome/browser/ui/global_error_service.h File chrome/browser/ui/global_error_service.h (right): http://codereview.chromium.org/7948003/diff/6001/chrome/browser/ui/global_error_service.h#newcode59 chrome/browser/ui/global_error_service.h:59: Profile* profile_; Can you ...

9 years, 3 months ago (2011-09-19 23:53:01 UTC) #6

sail

http://codereview.chromium.org/7948003/diff/6001/chrome/browser/ui/global_error_service.h File chrome/browser/ui/global_error_service.h (right): http://codereview.chromium.org/7948003/diff/6001/chrome/browser/ui/global_error_service.h#newcode59 chrome/browser/ui/global_error_service.h:59: Profile* profile_; On 2011/09/19 23:53:01, sky wrote: > Can ...

9 years, 3 months ago (2011-09-20 00:09:07 UTC) #7

Change committed as 101904

Expand Messages | Collapse Messages